sparse vector views remain sparse #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you need to call fun instead of +=, unless I don't understand the code |
|
absolutely, thanks! |
Codecov Report
@@ Coverage Diff @@
## main #416 +/- ##
=======================================
Coverage 93.20% 93.20%
=======================================
Files 12 12
Lines 7666 7700 +34
=======================================
+ Hits 7145 7177 +32
- Misses 521 523 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Alright this is good for review on my side |
|
@ViralBShah this could be a step towards fixing the views: #225 (comment) |
fredrikekre
reviewed
Jul 24, 2023
|
still haven't figured out what is causing the issue here |
SobhanMP
reviewed
Aug 2, 2023
Ensures that Union{} is not part of the output possibilities after type-piracy of Base.cat methods.
Refs JuliaLang/julia#50550
This little gadget creates a closure over Type{T} instead of DataType.
Fix JuliaLang/julia#50623
…ing the test suite (JuliaSparse#425)
…#423) * Respect IOContext in printing column indices * Add docstring to ColumnIndices
* add gitignore * remove unused argument
…se#430) Fix docs conflict
The generic `cat` does more shape analysis, that typed_cat does not always do (before either may then dispatch to _cat_t), so we can make this faster by calling it instead. Secondly, we can make `issparse` non-recursive once it hits a base case where all trailing elements are the same. This makes it much better at handling large splat, since we do not need to check each recursively smaller type down to the base case using generic code, and just generate one const method specialized on the full length instead. Fix JuliaLang/julia#51011
Co-authored-by: Marco Cognetta <cognetta.marco@gmail.com>
|
I copied over the tests from #225 and thereby found a little oversight. I'll push the easy fix right after, and then we can merge after tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #402 for sparse vectors. Closes #225. Fixes JuliaLang/julia#46355.
I also relaxed the assumption that the view indexing must be a Base.OneTo, otherwise this is too restrictive for vectors