Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep sparse solvers docs as before #552

Merged
merged 4 commits into from
Aug 11, 2024
Merged

Keep sparse solvers docs as before #552

merged 4 commits into from
Aug 11, 2024

Conversation

ViralBShah
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.09%. Comparing base (95fd7ff) to head (ed99a88).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   84.12%   84.09%   -0.04%     
==========================================
  Files          12       12              
  Lines        9110     9102       -8     
==========================================
- Hits         7664     7654      -10     
- Misses       1446     1448       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Member Author

ViralBShah commented Aug 7, 2024

We don't necessarily need to reproduce the solver docs in the SparseArrays section, since they are already in LinearAlgebra. But they are scattered all over LinearAlgebra. So even if we could just have a listing here, that links to the SparseMatrixCSC specific solver docs in LinearAlgebra, that should suffice.

cc @KristofferC

it conflicts with the one in julia stdlib.
@ViralBShah ViralBShah changed the title Mark sparse linalg API as non-canonical Keep sparse solvers docs as before Aug 11, 2024
@ViralBShah ViralBShah merged commit 55976a6 into main Aug 11, 2024
9 of 10 checks passed
@ViralBShah ViralBShah deleted the vs/docs branch August 11, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant