Diagonal-sandwiched triple product for SparseMatrixCSC #562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this,
This operation of pre- and post-multiplication by
Diagonal
s is not uncommon, as it scales the rows and columns of the sandwiched matrix. After this PR, the result is a sparse matrix as well.The new implementation changes the following behavior:
whereas, previously, this would have been a dense matrix of
NaN
s. This new behavior is consistent with sparse matrices having a strong zero.The implementation isn't optimal from a performance perspective, as it uses a sequence of multiplications instead of doing it all in one go. However, the performance may be improved iteratively.