remove invalid test for failing sprand(BigFloat) #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
approved these changes
Mar 24, 2022
Codecov Report
@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 89.18% 89.18%
=======================================
Files 7 7
Lines 5677 5677
=======================================
Hits 5063 5063
Misses 614 614 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@ViralBShah After this PR is merged, can we bump Julia master to use the latest commit of SuiteSparse#master? Or should we use a different branch of SuiteSparse, e.g. a release branch (to which we would backport this PR)? |
|
For now we are still just using |
|
See also JuliaLang/julia#44731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to test that
sprand(BigFloat, ...)throws aMethodError, as this function will work as soon as JuliaLang/julia#17629 is fixed.In particular, this test is blocking JuliaLang/julia#44714