compat fixes for Julia v1.8 #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
==========================================
- Coverage 84.56% 84.01% -0.56%
==========================================
Files 6 7 +1
Lines 784 807 +23
==========================================
+ Hits 663 678 +15
- Misses 121 129 +8
Continue to review full report at Codecov.
|
|
CI should be re-run in a few hours to make sure the tests run on a sufficiently up-to-date nightly version. |
|
@dkarrasch there's a doctest failure from a pivoted Cholesky being used where the non pivoted should be used. I've kicked off the CI again, but I'll take a closer look later if it fails. |
palday
approved these changes
Dec 16, 2021
|
You're welcome! |
ym-han
pushed a commit
to ym-han/GLM.jl
that referenced
this pull request
Dec 17, 2021
* compat fixes for Julia v1.8 * bump patch version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on JuliaLang/julia#41640.
Needs to be adjusted regarding the exact DEV-version number.