Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documenter.yml #569

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Update Documenter.yml #569

merged 5 commits into from
Nov 19, 2024

Conversation

andreasnoack
Copy link
Member

@andreasnoack andreasnoack commented Nov 19, 2024

Use specific versions of actions and enable caching.

This will probably fail for now. Looks like there are some changes to random numbers in Julia 1.11. This now uses a dataset from RDatasets instead of a random dataset. This change avoids the current failure on Julia 1.11 without braking 1.10. I also think it's better to use real datasets for examples. Furthermore, the PR now fixes several warnings currently present in the docs build.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.11%. Comparing base (0e145bd) to head (43f7546).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
+ Coverage   90.03%   90.11%   +0.08%     
==========================================
  Files           8        8              
  Lines        1124     1123       -1     
==========================================
  Hits         1012     1012              
+ Misses        112      111       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@palday
Copy link
Member

palday commented Nov 19, 2024

@andreasnoack can you set push_preview=true in docs/make.jl?

@andreasnoack andreasnoack force-pushed the an/deploydoc branch 4 times, most recently from 17fc090 to 77f53df Compare November 19, 2024 19:03
@andreasnoack
Copy link
Member Author

can you set push_preview=true in docs/make.jl?

Sure. I've also upgraded to Documenter@1 while visiting this

Copy link
Member

@palday palday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@andreasnoack andreasnoack merged commit 4bf2677 into master Nov 19, 2024
13 checks passed
@andreasnoack andreasnoack deleted the an/deploydoc branch November 19, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants