Add benchmark GHA #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Aug 22, 2023
|
|
||
| for i in 2:6 | ||
| n = 10^i | ||
| x = rand(MersenneTwister(42), n) |
There was a problem hiding this comment.
Would it be worth using StableRNGs here?
There was a problem hiding this comment.
I thought about it and probably not -- we don't care about the precise values and this is always run within the same Julia version for each new PR
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 90.56% 91.98% +1.41%
==========================================
Files 2 2
Lines 212 212
==========================================
+ Hits 192 195 +3
+ Misses 20 17 -3 ☔ View full report in Codecov by Sentry. |
|
merging -- it runs as expected on the current revision and fails to resolve the environment (which did not exist) on the older revision |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the action will necessarily fail until it's been merged because it uses
origin/HEADas the reference point and there are no benchmarks there.