Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fitting with a single data point and provide better error #83

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

andreasnoack
Copy link
Member

message when data arrays are empty

Fixes #82

@github-actions
Copy link

Benchmark Report for /home/runner/work/Loess.jl/Loess.jl

Job Properties

  • Time of benchmarks:
    • Target: 13 Sep 2023 - 11:48
    • Baseline: 13 Sep 2023 - 11:49
  • Package commits:
    • Target: 3948de
    • Baseline: 8bd2fd
  • Julia commits:
    • Target: bed2cd
    • Baseline: bed2cd
  • Julia command flags:
    • Target: None
    • Baseline: -Cnative,-J/opt/hostedtoolcache/julia/1.9.3/x64/lib/julia/sys.so,-g1,-O3,-e,using Pkg; Pkg.update()
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["random"]
  • ["ties"]

Julia versioninfo

Target

Julia Version 1.9.3
Commit bed2cd540a1 (2023-08-24 14:43 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1011-azure #11~22.04.1-Ubuntu SMP Wed Aug 23 19:26:19 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       1322 s          0 s         89 s       1358 s          0 s
       #2  2593 MHz        247 s          0 s        106 s       2391 s          0 s
  Memory: 6.759757995605469 GB (5073.71875 MB free)
  Uptime: 283.59 sec
  Load Avg:  0.94  0.47  0.19
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
  Threads: 1 on 2 virtual cores

Baseline

Julia Version 1.9.3
Commit bed2cd540a1 (2023-08-24 14:43 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.3 LTS
  uname: Linux 6.2.0-1011-azure #11~22.04.1-Ubuntu SMP Wed Aug 23 19:26:19 UTC 2023 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2593 MHz       1509 s          0 s        110 s       1943 s          0 s
       #2  2593 MHz        874 s          0 s        127 s       2539 s          0 s
  Memory: 6.759757995605469 GB (5454.71484375 MB free)
  Uptime: 363.21 sec
  Load Avg:  1.13  0.66  0.29
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, skylake-avx512)
  Threads: 1 on 2 virtual cores

@pkofod
Copy link

pkofod commented Sep 13, 2023

message when data arrays are empty

Fixes #82

great, thanks!

src/kd.jl Show resolved Hide resolved
@andreasnoack andreasnoack merged commit 9668e83 into master Sep 13, 2023
4 checks passed
@andreasnoack andreasnoack deleted the an/smalldata branch September 13, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One element case not handled correctly
3 participants