Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "DocStringExtensions" to "0.9" #53

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the DocStringExtensions package from 0.8 to 0.8, 0.9.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@tpapp tpapp force-pushed the compathelper/new_version/2022-05-27-01-50-01-036-2930285610 branch from 42c8cd7 to 5e34e71 Compare May 27, 2022 01:50
@tpapp tpapp merged commit 4ba50bd into master May 27, 2022
@tpapp tpapp deleted the compathelper/new_version/2022-05-27-01-50-01-036-2930285610 branch May 27, 2022 07:55
@devmotion
Copy link
Member

@tpapp The documentation was not built with DocStringExtensions 0.9 (https://github.com/JuliaStats/LogExpFunctions.jl/runs/6619211056?check_suite_focus=true#step:4:29), so it's unclear if it actually works correctly with that version. It seems Documenter holds it back as it is not compatible with DocStringExtensions 0.9 yet.

@tpapp
Copy link
Collaborator

tpapp commented May 27, 2022

Thanks for the heads-up. I think the changes are innocuous (mostly bug fixes) so it should be fine, we can always fix it later on if it breaks.

@jb-mackay
Copy link

@tpapp @devmotion would you be able to make a new release with this update?

@devmotion
Copy link
Member

Done: JuliaRegistries/General#64737

@jb-mackay
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants