Update Julia compat to 1.10 and update CI setup #213
+51
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll rebase on this PR once it's merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 91.61% 92.12% +0.50%
==========================================
Files 9 9
Lines 680 660 -20
==========================================
- Hits 623 608 -15
+ Misses 57 52 -5 ☔ View full report in Codecov by Sentry. |
timholy
approved these changes
Dec 12, 2024
.github/workflows/ci.yml
Outdated
| os: | ||
| - ubuntu-latest | ||
| - ubuntu-latest # Apple Silicon |
There was a problem hiding this comment.
Did you mean to have this comment on this line or the following one?
There was a problem hiding this comment.
Ah good catch, of course it should be moved to the following line.
devmotion
commented
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #212, it was proposed to update the Julia compat to 1.10. I opened a separate PR for this move since there are quite many
VERSIONchecks that we could (and should) get rid of in this update but these changes are really unrelated to #212 otherwise.I used the opportunity to update the CI setup, and in particular add tests with
min,ltsandpre.