Merge pull request #168 from JuliaStats/andreasnoack-patch-2

Implement one-argument cov2cor!
JuliaStats · Oct 21, 2024 · 1b67c17 · 1b67c17
2 parents c3721ed + 6e76739
commit 1b67c17
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Statistics.jl b/src/Statistics.jl
@@ -640,7 +640,7 @@ clampcor(x) = x
 
 # cov2cor!
 
-function cov2cor!(C::AbstractMatrix{T}, xsd::AbstractArray) where T
+function cov2cor!(C::AbstractMatrix{T}, xsd::AbstractArray=sqrt.(view(C, diagind(C)))) where T
     require_one_based_indexing(C, xsd)
     nx = length(xsd)
     size(C) == (nx, nx) || throw(DimensionMismatch("inconsistent dimensions"))
@@ -696,7 +696,7 @@ corzm(x::AbstractVector{T}) where {T} =
     T === Missing ? missing : one(float(nonmissingtype(T)))
 function corzm(x::AbstractMatrix, vardim::Int=1)
     c = unscaled_covzm(x, vardim)
-    return cov2cor!(c, collect(sqrt(c[i,i]) for i in 1:min(size(c)...)))
+    return cov2cor!(c)
 end
 corzm(x::AbstractVector, y::AbstractMatrix, vardim::Int=1) =
     cov2cor!(unscaled_covzm(x, y, vardim), sqrt(sum(abs2, x)), sqrt!(sum(abs2, y, dims=vardim)))