-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for quantile to operate over an entire Matrix #108
Conversation
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 96.91% 96.93% +0.01%
==========================================
Files 1 1
Lines 422 424 +2
==========================================
+ Hits 409 411 +2
Misses 13 13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Not sure what a meaningful way to work out the quantiles of a matrix inplace would look like, so remove the ! to make it clear it isn't inplace
Previous method caused type ambiguity, this is okay.
Why did you remove the |
Added a method which accepts q when determining quantiles over a matrix. This q is modified in place. Added a test to confirm this behaviour
Sorry your question about the in-place test confused me. Anyways, I think I've implemented the changes you requested. |
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
=========================================
Coverage ? 96.93%
=========================================
Files ? 1
Lines ? 424
Branches ? 0
=========================================
Hits ? 411
Misses ? 13
Partials ? 0 Continue to review full report at Codecov.
|
Thanks, and sorry for the delay! |
As discussed here if you pass a matrix to
quantile
you get an errorI made a small change which vectorises a matrix and provides the quantile for the whole matrix.
This change was originally made in StatsBase with PR 773.