Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quantile with Date and DateTime #153

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix quantile with Date and DateTime #153

merged 1 commit into from
Oct 3, 2023

Conversation

nalimilan
Copy link
Member

@nalimilan nalimilan commented Oct 2, 2023

Before #145 Date and DateTime were supported with quantile as long as the cut point falls between two equal values. Restore this behavior as some code may rely on this given that it is the most common situation with large datasets.

(Failures on Julia 1.x are expected as the fix that allows dropping float is only available on master. But we probably don't care as Statistics can only be upgraded on Julia 1.11 and later.)

Before #145 `Date` and `DateTime` were supported with `quantile` as long
as the cut point falls between two equal values. Restore this behavior
as some code may rely on this given that it is the most common situation
with large datasets.
@nalimilan
Copy link
Member Author

Thanks, I'm going to merge this keeping the CI on Julia 1.x given that the fix has been backported to Julia 1.10 and will normally be on 1.9.4 too.

@nalimilan nalimilan merged commit bfc6326 into master Oct 3, 2023
6 of 11 checks passed
@nalimilan nalimilan deleted the nl/quantiledate branch October 3, 2023 19:33
vtjnash added a commit to vtjnash/Statistics.jl that referenced this pull request Nov 3, 2023
Support was removed in JuliaStats#153, though that PR failed to set the correct compat bounds
nalimilan added a commit that referenced this pull request Nov 5, 2023
Before #145 `Date` and `DateTime` were supported with `quantile` as long
as the cut point falls between two equal values. Restore this behavior
as some code may rely on this given that it is the most common situation
with large datasets.
nalimilan added a commit to JuliaLang/julia that referenced this pull request Nov 5, 2023
This bumps Statistics to the latest commit of the release-1.10 branch in order to backport
JuliaStats/Statistics.jl#153.
nalimilan added a commit to JuliaLang/julia that referenced this pull request Nov 5, 2023
This bumps Statistics to the latest commit of the release-1.10 branch in order to backport
JuliaStats/Statistics.jl#153.
nalimilan added a commit to JuliaLang/julia that referenced this pull request Nov 5, 2023
This bumps Statistics to the latest commit of the release-1.10 branch in order to backport
JuliaStats/Statistics.jl#153.
nalimilan pushed a commit that referenced this pull request Nov 5, 2023
Support was removed in #153, though that PR failed to set the correct compat bounds
KristofferC pushed a commit to JuliaLang/julia that referenced this pull request Nov 9, 2023
This bumps Statistics to the latest commit of the release-1.10 branch in
order to backport JuliaStats/Statistics.jl#153.

See JuliaData/DataFrames.jl#3383. Cc: @bkamins
@George9000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants