Fix detection of NaN in median() #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reliable way to know only from the array eltype whether entries support `isnan` or not. Better leave to the compiler to optimize out the `isa Number` check when possible.
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
=========================================
Coverage ? 97.68%
=========================================
Files ? 1
Lines ? 388
Branches ? 0
=========================================
Hits ? 379
Misses ? 9
Partials ? 0 Continue to review full report at Codecov.
|
ararslan
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reliable way to know only from the array eltype whether entries support
isnanor not. Better leave to the compiler to optimize out theisa Numbercheck when possible.This works thanks to
isnan(::Number)added by JuliaLang/julia#38232.