Fix issue 110 from Formatting.jl #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use new Printf.format call directly, don't use macro
Rewrite printf handling, fix bugs
Fix bug with precision > length of string
Update requirements, improve tests
Update requirements, make work on v1.4 of Julia, improve tests
Fix %c left/right justification
Add GitHub workflows
Don't print decimal point when unnecessary: formatting PR #101
ScottPJones
force-pushed
the
spj/fixtypemin
branch
from
25d04e6
to
52a25df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is a bit repetitive - but since I plan on completely replacing most of this in the future to be closer to the code used for printf, it's fine for now.