Add tests for valid codepoints and iterate function #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Will merge once Travis succeeds. |
|
(The original utf8proc library didn't have any automated test suite at all, so we are slowly building that up.) |
|
Closing since this needs to be combined with #35. |
|
Yes, I didn't mean it as a criticism, about the lack of validity tests... things take time... and all of you are super busy (with far more important things for you all for your target for Julia of numerical computing)... |
|
Darn, I hate those bright red "closed" PRs! 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests (test/valid.c and test/iterate.c) test two of the main functions in the utf8proc package,
which previously had no validity tests...