Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dates as part of the stdlib #31

Merged
merged 5 commits into from
Nov 25, 2017
Merged

Support Dates as part of the stdlib #31

merged 5 commits into from
Nov 25, 2017

Conversation

omus
Copy link
Member

@omus omus commented Nov 22, 2017

No description provided.

@codecov
Copy link

codecov bot commented Nov 22, 2017

Codecov Report

Merging #31 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   92.36%   92.46%   +0.09%     
==========================================
  Files           4        4              
  Lines         249      252       +3     
==========================================
+ Hits          230      233       +3     
  Misses         19       19
Impacted Files Coverage Δ
src/bindings.jl 94.56% <100%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0355940...e9d04ea. Read the comment docs.

@omus
Copy link
Member Author

omus commented Nov 22, 2017

Will wait for JuliaLang/Compat.jl#413

Fixes the error message:

```
importing Dates into Main conflicts with an existing identifier
```

By avoiding writing the following:
```julia
import Compat: Dates
import Dates
```
@omus omus merged commit 9443a16 into master Nov 25, 2017
@omus omus deleted the cv/dates-stdlib branch December 2, 2017 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant