Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface test error if running testitem directly #178

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Surface test error if running testitem directly #178

merged 3 commits into from
Sep 18, 2024

Conversation

nickrobinson251
Copy link
Collaborator

@nickrobinson251 nickrobinson251 commented Sep 5, 2024 •
edited
Loading

So scripts doing this would return non-zero exit code

close #177

@nickrobinson251 nickrobinson251 mentioned this pull request Sep 5, 2024
Closed
@nickrobinson251 nickrobinson251 marked this pull request as ready for review September 11, 2024 12:52
Drvi
Drvi approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@Drvi Drvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickrobinson251 nickrobinson251 enabled auto-merge (squash) September 18, 2024 09:46
@nickrobinson251 nickrobinson251 merged commit 91ae620 into main Sep 18, 2024
7 checks passed
@nickrobinson251 nickrobinson251 deleted the npr-propogate-test-error branch September 18, 2024 09:59
@nickrobinson251 nickrobinson251 mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drvi Drvi Drvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests don't fail when exception is thrown
2 participants
@nickrobinson251 @Drvi