Throw if test_end_expr not a :block expr
#191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrobinson251
commented
Oct 3, 2024
src/ReTestItems.jl
Outdated
| @@ -272,6 +272,7 @@ function runtests( | |||
| (0 ≤ memory_threshold ≤ 1) || throw(ArgumentError("`memory_threshold` must be between 0 and 1, got $(repr(memory_threshold))")) | |||
| testitem_timeout > 0 || throw(ArgumentError("`testitem_timeout` must be a positive number, got $(repr(testitem_timeout))")) | |||
| timeout_profile_wait >= 0 || throw(ArgumentError("`timeout_profile_wait` must be a non-negative number, got $(repr(timeout_profile_wait))")) | |||
| test_end_expr.head === :quote || throw(ArgumentError("`test_end_expr` must be a `:quote` expression, got a `$(repr(test_end_expr.head))` expression")) | |||
There was a problem hiding this comment.
we require test_end_expr::Expr so safe to check .head here
nickrobinson251
force-pushed
the
npr-check-test-end-expr-type
branch
from
7cee77f to
0566742
Compare
nickrobinson251
changed the title
test_end_expr not a :quote blocktest_end_expr not a :block expr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help users find the correct usage