Allow constructing a FixedTimeZone from Dates.UTC and allow passing it to ZonedDateTime #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to ZonedDateTime
omus
reviewed
Dec 21, 2017
| @@ -3,6 +3,11 @@ import Compat.Dates | |||
| utc = FixedTimeZone("UTC") | |||
| warsaw = resolve("Europe/Warsaw", tzdata["europe"]...) | |||
|
|
|||
| # Converting from the stdlib UTC | |||
| @test FixedTimeZone(UTC()) == utc | |||
There was a problem hiding this comment.
I'm not sure I want to support using an instance of UTC as this is never actually utilized in Base. In fact they only ever seem to use the type so maybe the type should be redefined as abstract or rethought.
There was a problem hiding this comment.
Your interface currently says it accepts any TimeZone :P
There was a problem hiding this comment.
Fair. This happens to be the only TimeZone I don't like 😆
|
@iamed2 is this something you actually need? Dates only needs this for |
|
It's not something I need but I do keep running into this when trying to create a UTC ZDT and using the wrong UTC (there are so many) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.