fix some deprecation warnings

REQUIRE

@@ -1,6 +1,6 @@
 julia 0.6
 
-Compat 0.43
+Compat 0.62
 JSON
 MbedTLS
 HTTP 0.6.3

src/activity/events.jl

@@ -43,7 +43,7 @@ sig_header(request::HTTP.Request) = HTTP.header(request, "X-Hub-Signature")
 
 function has_valid_secret(request::HTTP.Request, secret)
     if has_sig_header(request)
-        secret_sha = "sha1="*bytes2hex(MbedTLS.digest(MbedTLS.MD_SHA1, HTTP.payload(request, String), secret))
+        secret_sha = "sha1="*bytes2hex(MbedTLS.digest(MbedTLS.MD_SHA1, HTTP.payload(request), secret))
         return sig_header(request) == secret_sha
     end
     return false

src/git/reference.jl

@@ -10,12 +10,12 @@ name(ref::Reference) = String(split(get(ref.ref), "refs/")[2])
 
 @api_default function reference(api::GitHubAPI, repo, ref_obj; options...)
     result = gh_get_json(api, "/repos/$(name(repo))/git/refs/$(name(ref_obj))"; options...)
-    return Reference.(result)
+    return Reference(result)
 end
 
 @api_default function references(api::GitHubAPI, repo; options...)
     results, page_data = gh_get_paged_json(api, "/repos/$(name(repo))/git/refs"; options...)
-    return Reference.(results), page_data
+    return Reference.((results,)), page_data
 end
 
 @api_default function create_reference(api::GitHubAPI, repo; options...)

src/utils/GitHubType.jl

@@ -82,7 +82,7 @@ end
 @generated function json2github(::Type{G}, data::Dict) where {G<:GitHubType}
     types = G.types
     fields = fieldnames(G)
-    args = Vector{Expr}(length(fields))
+    args = Vector{Expr}(undef, length(fields))
     for i in eachindex(fields)
         field, T = fields[i], first(types[i].parameters)
         key = field == :typ ? "type" : string(field)
@@ -125,27 +125,27 @@ end
 ###################
 
 function Base.show(io::IO, g::GitHubType)
-    print(io, "$(typeof(g)) (all fields are Nullable):")
-    for field in fieldnames(typeof(g))
-        val = getfield(g, field)
-        if !(isnull(val))
-            gotval = get(val)
-            println(io)
-            print(io, "  $field: ")
-            if isa(gotval, Vector)
-                print(io, typeof(gotval))
-            else
-                showcompact(io, gotval)
-            end
+    if get(io, :compact, false)
+        uri_id = namefield(g)
+        if isnull(uri_id)
+            print(io, typeof(g), "(…)")
+        else
+            print(io, typeof(g), "($(repr(get(uri_id))))")
         end
-    end
-end
-
-function Base.showcompact(io::IO, g::GitHubType)
-    uri_id = namefield(g)
-    if isnull(uri_id)
-        print(io, typeof(g), "(…)")
     else
-        print(io, typeof(g), "($(repr(get(uri_id))))")
+        print(io, "$(typeof(g)) (all fields are Nullable):")
+        for field in fieldnames(typeof(g))
+            val = getfield(g, field)
+            if !(isnull(val))
+                gotval = get(val)
+                println(io)
+                print(io, "  $field: ")
+                if isa(gotval, Vector)
+                    print(io, typeof(gotval))
+                else
+                    show(IOContext(io, :compact => true), gotval)
+                end
+            end
+        end
     end
 end

src/utils/requests.jl

@@ -92,7 +92,7 @@ get_page_links(r) = split(HTTP.header(r, "Link",), ",")
 function find_page_link(links, rel)
     relstr = "rel=\"$(rel)\""
     for i in 1:length(links)
-        if contains(links[i], relstr)
+        if occursin(relstr, links[i])
             return i
         end
     end

test/event_tests.jl

@@ -1,6 +1,6 @@
 include("commit_comment.jl")
 event_request = create_event()
-event_json = JSON.parse(HTTP.payload(event_request, String))
+event_json = JSON.parse(IOBuffer(HTTP.payload(event_request)))
 event = GitHub.event_from_payload!("commit_comment", event_json)
 
 @testset "WebhookEvent" begin

test/read_only_api_tests.jl

@@ -189,7 +189,7 @@ end
             @test entry["type"] == "blob"
 
             b = blob(github_jl, entry["sha"]; auth=auth)
-            @test contains(String(base64decode(replace(get(b.content),"\n" => ""))), "GitHub.jl")
+            @test occursin("GitHub.jl", String(base64decode(replace(get(b.content),"\n" => ""))))
 
             break
         end