Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use idle_timeout for the requests #109

Merged
merged 2 commits into from
Jun 4, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
language: julia
os:
- linux
- osx
julia:
- 0.6
- nightly
Expand Down
2 changes: 1 addition & 1 deletion REQUIRE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
julia 0.6

Compat 0.43
Compat 0.62
JSON
MbedTLS
HTTP 0.6.3
Expand Down
4 changes: 2 additions & 2 deletions src/activity/events.jl
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ sig_header(request::HTTP.Request) = HTTP.header(request, "X-Hub-Signature")

function has_valid_secret(request::HTTP.Request, secret)
if has_sig_header(request)
secret_sha = "sha1="*bytes2hex(MbedTLS.digest(MbedTLS.MD_SHA1, HTTP.payload(request, String), secret))
secret_sha = "sha1="*bytes2hex(MbedTLS.digest(MbedTLS.MD_SHA1, HTTP.payload(request), secret))
return sig_header(request) == secret_sha
end
return false
Expand Down Expand Up @@ -97,7 +97,7 @@ function handle_event_request(request, handle;
return HTTP.Response(204, "event ignored")
end

event = event_from_payload!(event_header(request), JSON.parse(HTTP.payload(request, String)))
event = event_from_payload!(event_header(request), JSON.parse(IOBuffer(HTTP.payload(request))))

if !(isa(repos, Nothing)) && !(from_valid_repo(event, repos))
return HTTP.Response(400, "invalid repo")
Expand Down
4 changes: 2 additions & 2 deletions src/git/reference.jl
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ name(ref::Reference) = String(split(get(ref.ref), "refs/")[2])

@api_default function reference(api::GitHubAPI, repo, ref_obj; options...)
result = gh_get_json(api, "/repos/$(name(repo))/git/refs/$(name(ref_obj))"; options...)
return Reference.(result)
return Reference(result)
end

@api_default function references(api::GitHubAPI, repo; options...)
results, page_data = gh_get_paged_json(api, "/repos/$(name(repo))/git/refs"; options...)
return Reference.(results), page_data
return Reference.((results,)), page_data
end

@api_default function create_reference(api::GitHubAPI, repo; options...)
Expand Down
42 changes: 21 additions & 21 deletions src/utils/GitHubType.jl
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ end
@generated function json2github(::Type{G}, data::Dict) where {G<:GitHubType}
types = G.types
fields = fieldnames(G)
args = Vector{Expr}(length(fields))
args = Vector{Expr}(undef, length(fields))
for i in eachindex(fields)
field, T = fields[i], first(types[i].parameters)
key = field == :typ ? "type" : string(field)
Expand Down Expand Up @@ -125,27 +125,27 @@ end
###################

function Base.show(io::IO, g::GitHubType)
print(io, "$(typeof(g)) (all fields are Nullable):")
for field in fieldnames(typeof(g))
val = getfield(g, field)
if !(isnull(val))
gotval = get(val)
println(io)
print(io, " $field: ")
if isa(gotval, Vector)
print(io, typeof(gotval))
else
showcompact(io, gotval)
end
if get(io, :compact, false)
uri_id = namefield(g)
if isnull(uri_id)
print(io, typeof(g), "(…)")
else
print(io, typeof(g), "($(repr(get(uri_id))))")
end
end
end

function Base.showcompact(io::IO, g::GitHubType)
uri_id = namefield(g)
if isnull(uri_id)
print(io, typeof(g), "(…)")
else
print(io, typeof(g), "($(repr(get(uri_id))))")
print(io, "$(typeof(g)) (all fields are Nullable):")
for field in fieldnames(typeof(g))
val = getfield(g, field)
if !(isnull(val))
gotval = get(val)
println(io)
print(io, " $field: ")
if isa(gotval, Vector)
print(io, typeof(gotval))
else
show(IOContext(io, :compact => true), gotval)
end
end
end
end
end
6 changes: 3 additions & 3 deletions src/utils/requests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ function github_request(api::GitHubAPI, request_method, endpoint;
_headers = convert(Dict{String, String}, headers)
!haskey(_headers, "User-Agent") && (_headers["User-Agent"] = "GitHub-jl")
if request_method == HTTP.get
r = request_method(merge(api_endpoint, query = params), _headers, redirect = allowredirects, status_exception = false)
r = request_method(merge(api_endpoint, query = params), _headers, redirect = allowredirects, status_exception = false, idle_timeout=20)
else
r = request_method(string(api_endpoint), _headers, JSON.json(params), redirect = allowredirects, status_exception = false)
r = request_method(string(api_endpoint), _headers, JSON.json(params), redirect = allowredirects, status_exception = false, idle_timeout=20)
end
handle_error && handle_response_error(r)
return r
Expand Down Expand Up @@ -92,7 +92,7 @@ get_page_links(r) = split(HTTP.header(r, "Link",), ",")
function find_page_link(links, rel)
relstr = "rel=\"$(rel)\""
for i in 1:length(links)
if contains(links[i], relstr)
if occursin(relstr, links[i])
return i
end
end
Expand Down
2 changes: 2 additions & 0 deletions test/commit_comment.jl
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
using Compat.Base64

function create_event()
data_base64 = "{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/comments/14047058","html_url":"https://github.com/JuliaCI/BenchmarkTrackers.jl/commit/32d35f285777b077d8b6a2521309d1ab646d2379#commitcomment-14047058","id":14047058,"user":{"login":"jrevels","id":3277443,"avatar_url":"https://avatars.githubusercontent.com/u/3277443?v=3","gravatar_id":"","url":"https://api.github.com/users/jrevels","html_url":"https://github.com/jrevels","followers_url":"https://api.github.com/users/jrevels/followers","following_url":"https://api.github.com/users/jrevels/following{/other_user}","gists_url":"https://api.github.com/users/jrevels/gists{/gist_id}","starred_url":"https://api.github.com/users/jrevels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrevels/subscriptions","organizations_url":"https://api.github.com/users/jrevels/orgs","repos_url":"https://api.github.com/users/jrevels/repos","events_url":"https://api.github.com/users/jrevels/events{/privacy}","received_events_url":"https://api.github.com/users/jrevels/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"32d35f285777b077d8b6a2521309d1ab646d2379","created_at":"2015-10-28T17:56:49Z","updated_at":"2015-10-28T17:56:49Z","body":"`RunBenchmarks(\"binary\", \"unary\")`"},"repository":{"id":44189107,"name":"BenchmarkTrackers.jl","full_name":"JuliaCI/BenchmarkTrackers.jl","owner":{"login":"JuliaCI","id":9957604,"avatar_url":"https://avatars.githubusercontent.com/u/9957604?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaCI","html_url":"https://github.com/JuliaCI","followers_url":"https://api.github.com/users/JuliaCI/followers","following_url":"https://api.github.com/users/JuliaCI/following{/other_user}","gists_url":"https://api.github.com/users/JuliaCI/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaCI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaCI/subscriptions","organizations_url":"https://api.github.com/users/JuliaCI/orgs","repos_url":"https://api.github.com/users/JuliaCI/repos","events_url":"https://api.github.com/users/JuliaCI/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaCI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaCI/BenchmarkTrackers.jl","description":"Track a Julia package's benchmark results as part of CI","fork":false,"url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl","forks_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/forks","keys_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/teams","hooks_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/events","assignees_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/tags","blobs_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/subscription","commits_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/merges","archive_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/downloads","issues_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaCI/BenchmarkTrackers.jl/releases{/id}","created_at":"2015-10-13T16:17:04Z","updated_at":"2015-10-22T14:45:04Z","pushed_at":"2015-10-28T17:52:36Z","git_url":"git://github.com/JuliaCI/BenchmarkTrackers.jl.git","ssh_url":"git@github.com:JuliaCI/BenchmarkTrackers.jl.git","clone_url":"https://github.com/JuliaCI/BenchmarkTrackers.jl.git","svn_url":"https://github.com/JuliaCI/BenchmarkTrackers.jl","homepage":null,"size":397,"stargazers_count":1,"watchers_count":1,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"},"organization":{"login":"JuliaCI","id":9957604,"url":"https://api.github.com/orgs/JuliaCI","repos_url":"https://api.github.com/orgs/JuliaCI/repos","events_url":"https://api.github.com/orgs/JuliaCI/events","members_url":"https://api.github.com/orgs/JuliaCI/members{/member}","public_members_url":"https://api.github.com/orgs/JuliaCI/public_members{/member}","avatar_url":"https://avatars.githubusercontent.com/u/9957604?v=3","description":"Continous Integration (CI) Support for the Julia Language"},"sender":{"login":"jrevels","id":3277443,"avatar_url":"https://avatars.githubusercontent.com/u/3277443?v=3","gravatar_id":"","url":"https://api.github.com/users/jrevels","html_url":"https://github.com/jrevels","followers_url":"https://api.github.com/users/jrevels/followers","following_url":"https://api.github.com/users/jrevels/following{/other_user}","gists_url":"https://api.github.com/users/jrevels/gists{/gist_id}","starred_url":"https://api.github.com/users/jrevels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrevels/subscriptions","organizations_url":"https://api.github.com/users/jrevels/orgs","repos_url":"https://api.github.com/users/jrevels/repos","events_url":"https://api.github.com/users/jrevels/events{/privacy}","received_events_url":"https://api.github.com/users/jrevels/received_events","type":"User","site_admin":false}}"

Expand Down
2 changes: 1 addition & 1 deletion test/event_tests.jl
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
include("commit_comment.jl")
event_request = create_event()
event_json = JSON.parse(HTTP.payload(event_request, String))
event_json = JSON.parse(IOBuffer(HTTP.payload(event_request)))
event = GitHub.event_from_payload!("commit_comment", event_json)

@testset "WebhookEvent" begin
Expand Down
6 changes: 3 additions & 3 deletions test/ghtype_tests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function test_show(g::GitHub.GitHubType)
@test repr(g) == String(take!(tmpio))

tmpio = IOBuffer()
showcompact(tmpio, g)
show(IOContext(tmpio, :compact => true), g)

@test "$(typeof(g))($(repr(name(g))))" == String(take!(tmpio))
end
Expand Down Expand Up @@ -540,7 +540,7 @@ end

test_show(hook_result)
end

@testset "Gist" begin
gist_json = JSON.parse("""
{
Expand Down Expand Up @@ -734,7 +734,7 @@ end
"updated_at": "2017-07-08T16:18:44"
}
""")

app_result = App(app_json)
@test name(app_result) == Int(app_json["id"])
end
Expand Down
2 changes: 1 addition & 1 deletion test/read_only_api_tests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ end
@test entry["type"] == "blob"

b = blob(github_jl, entry["sha"]; auth=auth)
@test contains(String(base64decode(replace(get(b.content),"\n" => ""))), "GitHub.jl")
@test occursin("GitHub.jl", String(base64decode(replace(get(b.content),"\n" => ""))))

break
end
Expand Down