Try to reduce risk of EOF error with POST requests #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a txcount field to the Request struct - Increment txcount after the body is written - Modify RetryRequest.isrecoverable to allow retry of non-idempotent requests if txcount is zero. - Modify StreamRequest to Wait for other pipelined reads to complete before sending a non-idempotent request body. This should decrease the chance of sending a POST body that ends up failing and can't be retried. - Remove yeild() after @async writebody. This should increase the chance that the startread() realises that the connection is dead before the body is written. Depends on: JuliaLang/MbedTLS.jl#124
These are the two https POST tests that fail because of JuliaLang/MbedTLS.jl#124 |
|
0.6 tests all pass w/ the new MbedTLS tag; 0.7 failures are unrelated (moving Sockets out of Base) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requests if txcount is zero.
before sending a non-idempotent request body. This should decrease
the chance of sending a POST body that ends up failing and can't be
retried.
that the startread() realises that the connection is dead before the
body is written.
Depends on: Try to fix deadlock JuliaLang/MbedTLS.jl#124