make http client based get requests work again

[amanica]

hi,
after struggling quite a bit with the new version of HTTP.jl (and julia 0.6.2) I finally figured out that the query parameters gets ignored when calling via the Client api. (I think a similar issue exists with HTTP.get function and friends)

With this fix it is working for me again. Let me know if you are happy with this and if I should attempt to add a test..

thanks
marius

[quinnj]

Looks good to me, but @samoconnor implemented this code path, so let's let him look at it.

[samoconnor]

This change looks good to me in the context of client.jl.

However, I think it might be time to deprecate client.jl and encourage people to use kw args like this: #192 (comment)

As it stands, the request(client::Client ... method exists as a place to implement all the deprecation messages for kw args that changed in v0.6. The only thing remaining in struct Client (aside form the kw args NamedTuple) is the cookiejar. But cookiejar= is really just a kw option like all the others, there isn't a compelling reason for it to have its own special field.

Note: default_cookie_jar handles the common case where the user just wants a single cookiejar per Julia session, so DEFAULT_CLIENT.cookies is redundant.

Also, HTTP.get(url) being routed through client.jl is a bug/oversight (a multiple dispatch gotcha).
It is intended to go to here: https://github.com/JuliaWeb/HTTP.jl/blob/master/src/HTTP.jl#L337

[samoconnor]

This commit addresses the routing of HTTP.get(url) though client.jl: 5d5614c
(@quinnj can you do a quick sanity check?)