-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using LibCURL_jll / MozillaCACerts_jll #75
Conversation
CI failure on Linux is returning cc: @staticfloat |
Related to: #57 |
Can you re-run CI and see if it fails with the latest LibCURL jll? |
Does the Julia build pull libcurl from this jll? Just like |
That's part of what JuliaLang/julia#35193 will provide |
I submitted a change to LibCURL_jll to store the mozilla ca bundle. It'll require some change here which I'll do once the jll update is pushed and registered, but hopefully that'll solve the cert issues here (and at many other places) |
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=========================================
- Coverage 7.51% 6.81% -0.71%
=========================================
Files 2 2
Lines 133 132 -1
=========================================
- Hits 10 9 -1
Misses 123 123
Continue to review full report at Codecov.
|
Everything looks good now. I want to validate these changes with FTPClient.jl but I'll need to do that tomorrow. |
Yeah, it's worth checking that the jll binary does ftp correctly. (BTW, it should also do http2 now) I tested these changes with SMTPClient.jl (which also had numerous reports of certificate problems), and they are all fixed with this change, waiting for a tag here. |
Changes work fine with FTPClient.jl. I did notice a failure but I can reproduce the failure without this PR. |
I used FTPClient.jl with these changes and the tests there did pass