[Mellanox] Add patch to disable hw-management thermal control shell script #14

Junchao-Mellanox · 2020-05-06T06:56:17Z

- Why I did it

There is already a user space thermal control feature. In order to avoid conflict, need to disable thermal control shell script on Mellanox hw-management side.

- How I did it

Add a patch for hw-mgmt to disable thermal control shell script at build time.

- How to verify it

Apply the patch and see the service has been disabled.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

…cript

stephenxs

As there has already been one patch prefixed with 0001- 0001-Make-hw-mgmt-SimX-compatiable.patch, should this be 0002-?

Junchao-Mellanox · 2020-05-06T09:15:14Z

As there has already been one patch prefixed with 0001- 0001-Make-hw-mgmt-SimX-compatiable.patch, should this be 0002-?

Now the SimX patch cannot be applied to hw-mgmt, and once Simx patch fail, the rest patch will not be applied too, I have to prefix my patch with 0001 to make sure it can be applied. Should we change the Makefile to make sure that one patch fail would not affect other patch?

stephenxs · 2020-05-06T09:23:43Z

Understood.
Even though having two patches with the same sequence number is not good and neither is that a stable way to make your patch can be installed.
I think you can ask Mykola to fix it or remove the problematic patch and then add yours.
To improve the makefile by skipping problematic patches is better but I think it's better to do that in another PR.

Junchao-Mellanox · 2020-05-06T09:49:06Z

Understood.
Even though having two patches with the same sequence number is not good and neither is that a stable way to make your patch can be installed.
I think you can ask Mykola to fix it or remove the problematic patch and then add yours.
To improve the makefile by skipping problematic patches is better but I think it's better to do that in another PR.

Already sent an email to Mykola. You are right, two patches with the same sequence number is not good. I'll work with Mykola to fix this.

liat-grozovik · 2020-05-06T10:45:31Z

should this be taken even if thermal control is not part of 201911?

Junchao-Mellanox · 2020-05-06T11:15:59Z

if thermal control is not part of 201911, this patch should not be applied.

…l/4364/files has already handle it

Junchao-Mellanox · 2020-05-07T08:44:05Z

Community PR sonic-net#4550

* [BFN] Updated platform APIs impl Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Extended BFN platform SFP APIs implementation * Update sfp.py * [BFN] Extended SFP platform plugin implementation Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] Extended Fans platform plugin implementation * [BFN] divided classes Fan and FanDrawer into 2 files * Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> What I did Add get_model() function Add get_low_critical_threshold() function Change __get(...) function. How I did it Differnece from previous implementation of __get(...) function is return real value or -9999.9 if value is not provided by thrift API * Add get_presence() function and revised __get() function Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * [BFN] Updated PSU platform APIs impl Signed-off-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com> * Added BFN PSU cache (#9) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] Fans and Fantray platform APIs update (#7) * [BFN] Updated SFP platform APIs (#10) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * [BFN] Updated platform API for thermal (#8) * Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * Revert "[BFN] Fans and Fantray platform APIs update (#7)" (#11) This reverts commit c62a733. * Add support health monitor system (#15) Signed-off-by: Petro Bratash <petrox.bratash@intel.com> * Update chassis.py * [BFN] Updated FANs and FAN Tray platform API (#14) * Fix fix_alignment (#17) Signed-off-by: Petro Bratash <petrox.bratash@intel.com> * [BFN] Improvement show environment (#16) * Added PSU temperature skip into platform.json (#18) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Do not skip psud on Newport Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] fix fan status from Not OK to Ok (#19) * [BFN] Updated SFP platform plugin (#13) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * [DPB] Fix typo for Ethernet0 2x200G[100G,40G] breakout mode (#21) Signed-off-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com> * [barefoot] Tmp fix vendor_rev (#22) Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * Fixed python issues in sonic_platform/fan_drawer.py Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Updated fan_drawer.py * Fixing trailing white spaces in fan_drawer.py * [BFN] Fix thrift for SFPs API Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com> * In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [Newport] Thermal manager (#23) * Signed-off-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> * Revert "In platform.json, replaced 'false' with '0' to workaround ast.literal_eval() issue" This reverts commit 1e73127. * Removed 'controllable' options from platform.json to fix factory default config generation Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * Update thermal_manager.py * Migrated SFP plugin to sonic_xcvr API (#30) Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> Co-authored-by: KostiantynYarovyiBf <kostiantynx.yarovyi@intel.com> Co-authored-by: Vadym Yashchenko <vadymx.yashchenko@intel.com> Co-authored-by: Dmytro Lytvynenko <dmytrox.lytvynenko@intel.com> Co-authored-by: Volodymyr Boiko <volodymyrx.boiko@intel.com> Co-authored-by: Petro Bratash <petrox.bratash@intel.com> Co-authored-by: Mykola Gerasymenko <mykolax.gerasymenko@intel.com>

[sonic-linkmgrd][master] submodule update ef1f5eb Jing Zhang Feb 3 09:37:25 2022 [linkmgrd] linkmgrd subscribes MUX_CABLE_INFO table to handle peer OIR events (#17) bcd74b4 Jing Zhang Feb 1 09:52:00 2022 Collect ICMP packet loss information (#14) sign-off: Jing Zhang zhangjing@microsoft.com

[sonic-linkmgrd][202012] submodule update ef1f5eb Jing Zhang Feb 3 09:37:25 2022 [linkmgrd] linkmgrd subscribes MUX_CABLE_INFO table to handle peer OIR events (#17) bcd74b4 Jing Zhang Feb 1 09:52:00 2022 Collect ICMP packet loss information (#14) sign-off: Jing Zhang zhangjing@microsoft.com

#### Why I did it Update sonic-host-services submodule to include below commits: ``` bc8698d Merge pull request #21 from abdosi/feature 557a110 Fix the issue where if dest port is not specified in ACL rule than for multi-asic where we create NAT rule to forward traffic from Namespace to host fail with exception. 6e45acc (master) Merge pull request #14 from abdosi/feature 4d6cad7 Merge remote-tracking branch 'upstream/master' into feature bceb13e Install libyang to azure pipeline (#20) 82299f5 Merge pull request #13 from SuvarnaMeenakshi/cacl_fabricns 15d3bf4 Merge branch 'master' into cacl_fabricns de54082 Merge pull request #16 from ZhaohuiS/feature/caclmgrd_external_client_warning_log b4b368d Add warning log if destination port is not defined d4bb96d Merge branch 'master' into cacl_fabricns 35c76cb Add unit-test and fix typo. 17d44c2 Made Changes to be Python 3.7 compatible 978afb5 Aligning Code 1fbf8fb Merge remote-tracking branch 'upstream/master' into feature 7b8c7d1 Added UT for the changes 91c4c42 Merge pull request #9 from ZhaohuiS/feature/caclmgrd_external_client 7c0b56a Add 4 test cases for external_client_acl, including single port and port range for ipv4 and ipv6 b71e507 Merge remote-tracking branch 'origin/master' into HEAD d992dc0 Merge branch 'master' into feature/caclmgrd_external_client bd7b172 DST_PORT is configuralbe in json config file for EXTERNAL_CLIENT_ACL f9af7ae [CLI] Move hostname, mgmt interface/vrf config to hostcfgd (#2) 70ce6a3 Merge pull request #10 from sujinmkang/cold_reset 29be8d2 Added Support to render Feature Table using Device running metadata. Also added support to render 'has_asic_scope' field of Feature Table. 3437e35 [caclmgrd][chassis]: Add ip tables rules to accept internal docker traffic from fabric asic namespaces. 8720561 Fix and add hardware reboot cause determination tests 0dcc7fe remove the empty bracket if no hardware reboot cause minor e47d831 fix the wrong expected result comparision ef86b53 Fix startswith Attribute error 8a630bb fix mock patch 8543ddf update the reboot cause logic and update the unit test 53ad7cd fix the mock patch function 7c8003d fix the reboot-cause regix for test 1ba611f fix typo 25379d3 Add unit test case a56133b Add hardware reboot cause as actual reboot cause for soft reboot failed c7d3833 Support Restapi/gnmi control plane acls f6ea036 caclmgrd: Don't block traffic to mgmt by default a712fc4 Update test cases adc058b caclmgrd: Don't block traffic to mgmt by default 06ff918 Merge pull request #7 from bluecmd/patch-1 e3e23bc ci: Rename sonic-buildimage repository e83a858 Merge pull request #4 from kamelnetworks/acl-ip2me-test f5a2e50 [caclmgrd]: Tests for IP2ME rules generation ```

Signed-off-by: Vivek Reddy <vkarri@nvidia.com> [Nvidia] Enable iproute2 & fix mft build (#16) * Enable iproute2 as the SDK is also built Signed-off-by: Vivek Reddy <vkarri@nvidia.com> * [Nvidia] Dont use mkbmdeb method of dkms to build the package Signed-off-by: Vivek Reddy <vkarri@nvidia.com> * Added linux image to the Depends section of mft Signed-off-by: Vivek Reddy <vkarri@nvidia.com> [Nvidia] [Bookworm] Separate KERNEL_MFT into a new target (sonic-net#16782) * [Nvidia] Seperate KERNEL_MFT into a new target because of kernel header dependency Signed-off-by: Vivek Reddy <vkarri@nvidia.com> * Update linux-kernel submodule Signed-off-by: Vivek Reddy <vkarri@nvidia.com> * Fix paralell build problem Signed-off-by: Vivek Reddy <vkarri@nvidia.com> --------- Signed-off-by: Vivek Reddy <vkarri@nvidia.com>

…sonic-net#17730) #### Why I did it src/dhcpmon ``` * fc20a97 - (HEAD -> master, origin/master, origin/HEAD) [202311][counter] Clear counter table when dhcpmon init (#14) (2 hours ago) [Yaqiang Zhu] ``` #### How I did it #### How to verify it #### Description for the changelog

…sonic-net#17750) #### Why I did it src/dhcpmon ``` * 2443073 - (HEAD -> 202311, origin/202311) [counter] Clear counter table when dhcpmon init (#14) (#16) (2 days ago) [Yaqiang Zhu] ``` #### How I did it #### How to verify it #### Description for the changelog

Why I did it Advance dhcpmon submodule head Work item tracking Microsoft ADO (number only): 26270786 How I did it fc20a97 Yaqiang Zhu Wed Jan 10 09:11:25 2024 +0800 [202311][counter] Clear counter table when dhcpmon init (#14) bace2e0 Yaqiang Zhu Fri Jan 5 11:29:21 2024 +0800 [counter] Clear counter table when dhcpmon init (#14) How to verify it

[Mellanox] Add patch to disable hw-management thermal control shell s…

3afc673

…cript

stephenxs requested changes May 6, 2020

View reviewed changes

Remove SimX patch since https://github.com/Azure/sonic-buildimage/pul…

68f7aa7

…l/4364/files has already handle it

stephenxs approved these changes May 7, 2020

View reviewed changes

mykolaf approved these changes May 7, 2020

View reviewed changes

Junchao-Mellanox closed this May 7, 2020

Junchao-Mellanox deleted the dis-hw-thermal branch December 15, 2020 01:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Mellanox] Add patch to disable hw-management thermal control shell script #14

[Mellanox] Add patch to disable hw-management thermal control shell script #14

Junchao-Mellanox commented May 6, 2020 •

edited

Loading

stephenxs left a comment

Junchao-Mellanox commented May 6, 2020

stephenxs commented May 6, 2020

Junchao-Mellanox commented May 6, 2020

liat-grozovik commented May 6, 2020

Junchao-Mellanox commented May 6, 2020

Junchao-Mellanox commented May 7, 2020

[Mellanox] Add patch to disable hw-management thermal control shell script #14

[Mellanox] Add patch to disable hw-management thermal control shell script #14

Conversation

Junchao-Mellanox commented May 6, 2020 • edited Loading

stephenxs left a comment

Choose a reason for hiding this comment

Junchao-Mellanox commented May 6, 2020

stephenxs commented May 6, 2020

Junchao-Mellanox commented May 6, 2020

liat-grozovik commented May 6, 2020

Junchao-Mellanox commented May 6, 2020

Junchao-Mellanox commented May 7, 2020

Junchao-Mellanox commented May 6, 2020 •

edited

Loading