forked from sonic-net/sonic-buildimage
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Remove PSU set speed API #190
Open
Junchao-Mellanox
wants to merge
2
commits into
master
Choose a base branch
from
master_remove_psu_set_speed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI passed 2936 |
keboliu
approved these changes
Sep 27, 2023
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Mar 18, 2024
…lly (sonic-net#18076) #### Why I did it src/sonic-gnmi ``` * d56712a - (HEAD -> master, origin/master, origin/HEAD) Update GNMI path schema (#197) (4 days ago) [ganglv] * 758ec18 - Call flag.Parse() to parse global flags like -logtostderr (#198) (5 days ago) [Zain Budhwani] * 736e3b4 - Add signal handler to stop gnmi server for when sigterm or sigquit is called (#189) (3 weeks ago) [Zain Budhwani] * 5b59c57 - Fix sonic string in osversion/build (#190) (4 weeks ago) [Zain Budhwani] * d8d15c7 - Enable unit tests and code coverage for telemetry.go (#186) (5 weeks ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Apr 15, 2024
…lly (sonic-net#18258) #### Why I did it src/sonic-gnmi ``` * d59e436 - (HEAD -> 202311, origin/202311) Fix sonic string in osversion/build (#190) (3 weeks ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Jul 29, 2024
…lly (sonic-net#18256) #### Why I did it src/sonic-gnmi ``` * 71ae185 - (HEAD -> 202305, origin/202305) Merge pull request #202 from sonic-net/revert-191-cherry/202305/190 (82 minutes ago) [StormLiangMS] |\ | failure_prs.log e2b78b4 - (origin/revert-191-cherry/202305/190) Revert "Fix sonic string in osversion/build (#190)" (2 hours ago) [StormLiangMS] |/ * b431273 - Account for GLOBAL key in PFC_WD (#178) (6 days ago) [Zain Budhwani] * e1af33f - Merge pull request #199 from abdosi/202305 (6 days ago) [StormLiangMS] |\ | failure_prs.log f7e216b - Update db_client.go (6 days ago) [abdosi] |/ * ec3f56d - Fix sonic string in osversion/build (#190) (9 days ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Jul 29, 2024
…lly (sonic-net#18674) #### Why I did it src/sonic-gnmi ``` * 395a246 - (HEAD -> 202305, origin/202305) Merge pull request #205 from sonic-net/revert-202-revert-191-cherry/202305/190 (23 hours ago) [StormLiangMS] * 92d3363 - (origin/revert-202-revert-191-cherry/202305/190) Merge branch '202305' into revert-202-revert-191-cherry/202305/190 (9 days ago) [StormLiangMS] * 0f36f52 - Revert "Revert "[action] [PR:190] Fix sonic string in osversion/build (#190)"" (3 weeks ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Based on new mellanox thermal control design, PSU fan speed is controlled by hw-management-tc service and PSU firmware. It is not allowed for user to control PSU fan speed via platform API.
Work item tracking
How I did it
Remove set_speed API for PSU fan
How to verify it
unit test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)