Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[port auto-neg] Add yang model for port auto-neg feature #54

Closed
wants to merge 3 commits into from
Closed

[port auto-neg] Add yang model for port auto-neg feature #54

wants to merge 3 commits into from

Conversation

Junchao-Mellanox
Copy link
Owner

- Why I did it

Add yang model for port auto-neg feature

- How I did it

Add fields adv_speeds, interface_type, adv_interface_types, autoneg

- How to verify it

Run build

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@vadymhlushko-mlnx
Copy link

LGTM, but you need to add the tests, you can use this PR as an example.
When the tests will be ready, please ask @praveen-li to review them.

@Junchao-Mellanox
Copy link
Owner Author

Sure, will update later.

@Junchao-Mellanox
Copy link
Owner Author

@vadymhlushko-mlnx could you review again?

@vadymhlushko-mlnx
Copy link

If You add a new leaf in YANG Models:
Then please add the corresponding config in the same format as in configDB.json to the next file:
sonic-buildimage/src/sonic-yang-models/tests/yang_model_tests/yangTest.json under the key "SAMPLE_CONFIG_DB_JSON"

Then please build both:
sonic_yang_mgmt-1.0-py3-none-any.whl
sonic_yang_models-1.0-py3-none-any.whl

Build tests will make sure, that translation works for new leaves in YANG models.

@Junchao-Mellanox
Copy link
Owner Author

Added new field to SAMPLE_CONFIG_DB_JSON and verified with:

sonic_yang_mgmt-1.0-py3-none-any.whl
sonic_yang_models-1.0-py3-none-any.whl

@Junchao-Mellanox
Copy link
Owner Author

@vadymhlushko-mlnx could you review again?

@vadymhlushko-mlnx
Copy link

@vadymhlushko-mlnx could you review again?

LGTM

@Junchao-Mellanox
Copy link
Owner Author

Could you approve it so that I can run a CI?

@vadymhlushko-mlnx
Copy link

Could you approve it so that I can run a CI?

Please add me to the "Reviewers" section

@Junchao-Mellanox
Copy link
Owner Author

i suppose u can directly review it by clicking "Files Changed"->"Review changes"

vadymhlushko-mlnx
vadymhlushko-mlnx approved these changes Feb 10, 2021
View reviewed changes
Copy link

@vadymhlushko-mlnx vadymhlushko-mlnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praveen-li
Copy link

It should be marked as Yang project PR, and should be discussed once in the yang workgroup. thx.

@Junchao-Mellanox
Copy link
Owner Author

sonic-net#6948

Junchao-Mellanox pushed a commit that referenced this pull request May 6, 2022
@zjswhhh
[202012][sonic-linkmgrd] Submodule Update (sonic-net#10345)
9fd75ff 
[202012][sonic-linkmgrd]Submodule update

8507629 Jing Zhang      Mon Apr 4 10:25:22 2022 -0700   Lower unsolicited MUX state change notification log level to WARNING #57
17d217d Longxiang Lyu   Mon Mar 21 12:15:19 2022 +0800  Enhance clang format (#46)
c72fa2a Jing Zhang      Fri Apr 1 12:23:29 2022 -0700   Disable the feature that decreases link probe interval for measuring switch overhead #49 (#54)
256b01b Jing Zhang      Thu Mar 31 16:20:00 2022 -0700  Update link prober metrics posting logics #50 #53
dfd48d0 Jing Zhang      Wed Mar 23 16:27:45 2022 -0700  Decrease link probing interval after switchover to better determine the overhead of a toggle #43 (#48)

sign-off: Jing Zhang zhangjing@microsoft.com
Junchao-Mellanox pushed a commit that referenced this pull request Jul 7, 2022
@Pterosaur
[submodule]: Update submodule for wpa-supplicant (sonic-net#11264)
94556d3 
3f43852b8 [sonic_operators.cpp]: Increasing select timeout (#55)
a1142e251  [sonic_operators.cpp] Update sonic_db_manager::get_counter (#56)
1069d2dd4 [sonic_operators.cpp]: Fixbug wait with false positive to return success (#54)

Signed-off-by: Ze Gan <ganze718@gmail.com>
Junchao-Mellanox pushed a commit that referenced this pull request Aug 17, 2022
@Pterosaur @yxieca
[submodule]: Update submodule for wpa-supplicant (sonic-net#11264)
7d832d1 
3f43852b8 [sonic_operators.cpp]: Increasing select timeout (#55)
a1142e251  [sonic_operators.cpp] Update sonic_db_manager::get_counter (#56)
1069d2dd4 [sonic_operators.cpp]: Fixbug wait with false positive to return success (#54)

Signed-off-by: Ze Gan <ganze718@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadymhlushko-mlnx vadymhlushko-mlnx vadymhlushko-mlnx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Junchao-Mellanox @vadymhlushko-mlnx @praveen-li