Revert "[scripts/fast-reboot] Shutdown remaining containers through systemd (#2133)" #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystemd (sonic-net#2133)" This reverts commit 23e9398.
keboliu
approved these changes
May 11, 2022
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Mar 13, 2024
…onic-net#3153) * Fix the sfputil treats page number as decimal instead of hexadecimal (#22) Fix the sfputil treats page number as decimal instead of hexadecimal Signed-off-by: Kebo Liu <kebol@nvidia.com> * remove unreachable code Signed-off-by: Kebo Liu <kebol@nvidia.com> --------- Signed-off-by: Kebo Liu <kebol@nvidia.com>
Junchao-Mellanox
pushed a commit
that referenced
this pull request
Apr 18, 2024
…decimal (sonic-net#3153) (sonic-net#3160) * Fix the sfputil treats page number as decimal instead of hexadecimal (#22) Signed-off-by: Kebo Liu <kebol@nvidia.com> Co-authored-by: Kebo Liu <kebol@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 23e9398.
What I did
Revert "[scripts/fast-reboot] Shutdown remaining containers through systemd (sonic-net#2133)"
This reverted PR is part of a story that refactors warm/fast shutdown sequence to gracefully stop services instead of killing them without any ordering and dependency requirements which creates several issues and is error prone for the future.
This PR must come together with sonic-net/sonic-buildimage#10510.
However, #10510 is blocked due to an issue in swss-common sonic-net/sonic-swss-common#603
And a fix by MSFT is in review sonic-net/sonic-swss-common#606
I am reverting it because its dependency is still blocked and we cannot update submodule pointer. Once the dependency of the reverted PR is resolved, it shall be re-commited.
How I did it
Revert it
How to verify it
Run build
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)