Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default chroma decoder for PAL/PAL-M #66

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Change default chroma decoder for PAL/PAL-M #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/tbc_video_export/opts/opts_ldtools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ def add_ldtool_opts(parent: argparse.ArgumentParser) -> None:
help="Set the chroma decoder to be used.\n"
"Available decoders:\n\n"
f" {ChromaDecoder.MONO} (default for LUMA)\n\n"
f" {ChromaDecoder.PAL2D}\n"
f" {ChromaDecoder.TRANSFORM2D} (default for PAL/PAL-M S-Video)\n"
f" {ChromaDecoder.PAL2D} (default for PAL/PAL-M S-Video)\n"
f" {ChromaDecoder.TRANSFORM2D}\n"
f" {ChromaDecoder.TRANSFORM3D} (default for PAL/PAL-M CVBS)\n\n"
f" {ChromaDecoder.NTSC1D}\n"
f" {ChromaDecoder.NTSC2D} (default for NTSC S-Video and CVBS)\n"
Expand Down
2 changes: 1 addition & 1 deletion src/tbc_video_export/program_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def decoder_chroma(self) -> ChromaDecoder:
case VideoSystem.PAL | VideoSystem.PAL_M:
# pal chroma
if TBCType.CHROMA in self.tbc_types:
decoder = ChromaDecoder.TRANSFORM2D
decoder = ChromaDecoder.PAL2D

# pal combined
if self.tbc_types == TBCType.COMBINED:
Expand Down
4 changes: 2 additions & 2 deletions tests/test_wrappers_ldtools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ class TestWrappersChromaDecoder:
input_opts=[],
expected_opts=[
{"--luma-nr", "0"},
{"-f", "transform2d"},
{"-f", "pal2d"},
{"--input-json", f"{get_path('pal_svideo')}.tbc.json"},
{"PIPE_IN", "PIPE_OUT"},
],
Expand Down Expand Up @@ -280,7 +280,7 @@ class TestWrappersChromaDecoder:
input_opts=[],
expected_opts=[
{"--luma-nr", "0"},
{"-f", "transform2d"},
{"-f", "pal2d"},
{"--input-json", f"{get_path('palm_svideo')}.tbc.json"},
{"PIPE_IN", "PIPE_OUT"},
],
Expand Down