Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix completion performance regression on v1.6: #355

Merged
merged 1 commit into from
Oct 16, 2020
+6 −1
Merged

fix completion performance regression on v1.6: #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,12 @@ iskeyword(word::Symbol) = word in keys(Docs.keywords)
iskeyword(word::AbstractString) = iskeyword(Symbol(word))

ismacro(ct::AbstractString) = startswith(ct, '@') || endswith(ct, '"')
ismacro(f::Function) = startswith(string(methods(f).mt.name), "@")
# xref: https://github.com/JuliaLang/julia/issues/38059
function ismacro(@nospecialize(f::FT)) where {FT<:Function}
isdefined(FT, :name) || return false # XXX: this check might not be necessary
tn = FT.name::Core.TypeName
return occursin('@', string(tn.name))
end

# uri utilties
# ------------
Expand Down