INT-6697 - Initial implementation #1
Conversation
…ts that don't return standard HTTP errors.
adam-in-ict
added
minor
.env.example
Outdated
| BASE_URL= | ||
| USERNAME= |
There was a problem hiding this comment.
We shouldn't use USERNAME anymore:
JupiterOne/sdk#817
There was a problem hiding this comment.
Thanks for the catch! Updated in latest commits.
| @@ -24,9 +24,10 @@ jobs: | |||
| with: | |||
| node-version: 14.x | |||
| cache: yarn | |||
| cache-dependency-path: '**/yarn.lock' | |||
There was a problem hiding this comment.
Should we contribute this to the template?
There was a problem hiding this comment.
I still can't get the test to pass, so didn't contribute it back in yet.
src/config.ts
Outdated
| type: 'string', | ||
| }, | ||
| clientSecret: { | ||
| username: { |
There was a problem hiding this comment.
Same as other comment above.
| // The owners array contains complex objects we can't directly map | ||
| // to a property, so reduce it down to an array of email addresses. | ||
| owners: source.owners_v2?.map((item) => item.email), | ||
| // the API doesn't provide a classification, but this is a required field |
There was a problem hiding this comment.
I think this strategy is good but we should change owners to owner.
There was a problem hiding this comment.
I thought about that, but it's technically an array of multiple owners, so I wasn't sure if it'd be false advertising to make it a singular owner field.
| export function createFindingEntity(finding: FindingRow): Entity { | ||
| return createIntegrationEntity({ | ||
| entityData: { | ||
| source: [], |
There was a problem hiding this comment.
Also intentionally leaving out rawData here?
There was a problem hiding this comment.
Yes. Their documentation made me unsure if we could guarantee there'd never be sensitive information passed back.
Co-authored-by: Matthew Zember <59547983+zemberdotnet@users.noreply.github.com>
…JupiterOne/graph-bigid into INT-6697-initial-implementation
|
🚀 PR was released in |
j1-internal-automation
added
the
released
Description
Thank you for contributing to a JupiterOne integration!
Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change.
Summary
Initial BigID implementation
Entities
The following entities are created:
_type_classbigid_accountAccountbigid_datasourceDataCollectionbigid_pii_objectRecordbigid_userUserRelationships
The following relationships are created:
_type_class_typebigid_accountbigid_userbigid_accountbigid_datasourcebigid_datasourcebigid_pii_objectType of change
Please leave any irrelevant options unchecked.
not work as expected)
Checklist
General Development Checklist:
Integration Development Checklist:
Please leave any irrelevant options unchecked.
endpoints, and have documented any additional permissions in
jupiterone.md, where necessary.API
using
dependsOnJupiterOne data model
to ensure that any new entities/relationships, and relevant properties,
match the recommended model for this class of data
CHANGELOG.mdfile to describe my changesreviewed all existing managed questions referencing the entities,
relationships, and their property names, to ensure those questions still
function with my changes.