Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contentful-common-strings package. #32

Merged
merged 23 commits into from
Jun 24, 2021
Merged

Add contentful-common-strings package. #32

merged 23 commits into from
Jun 24, 2021

Conversation

toolness
Copy link
Contributor

@toolness toolness commented Jun 17, 2021 •
edited
Loading

This factors out the common logic in JustFixNYC/tenants2#2125 and JustFixNYC/who-owns-what#482 into its own reusable package, @justfixnyc/contentful-common-strings.

To do

  • Plop the CLI in node_modules/.bin.
  • Add command-line arguments to the CLI so the defaults can be overridden.
  • Add a real manual test.
  • Add docs.
  • Before publishing, update the CHANGELOG.md with the release date.

This was referenced Jun 17, 2021
Merged
Merged
@toolness
Convert CLI to typescript, use cross-fetch.
804ec3a
@toolness
Use rollup to build cli bundle.
656e648
@toolness
Add a 'bin' entry to package.json.
b1d2b3a
@toolness
Use yargs for argument parsing.
cb0fdc4
@toolness
Allow all options of config to be overridden via CLI.
d5bd3ba
@toolness
Better export names.
7e41b7d
@toolness
Make manual test page useful.
60867b2
@toolness
Start http server on watch.
b469333
@toolness
Add some docs, re-export types.
44cc2c5
@toolness
Add more docs.
d1d0c03
@toolness
Refactor manual test.
933ac6b
@toolness
Add configuration form to manual test page.
fe1a6ad
@toolness
Allow 'tag' to be set to the empty string in manual test.
2af84e4
@toolness
Add changelog.
dc30563
@toolness
CLI demands at least one command.
3687263
@toolness
ok LET'S DO THIS
3087b52
@toolness
Um hi lerna
9a97101
@toolness
Publish
e4538d2 
 - @justfixnyc/contentful-common-strings@0.0.1
@toolness
lol lerna u suk
f1a1983
@toolness
Publish
9040cbe 
 - @justfixnyc/contentful-common-strings@0.0.1
@toolness
sigh, lerna
d7a321a
@toolness
Publish
7e005ea 
 - @justfixnyc/contentful-common-strings@0.0.2
@toolness toolness marked this pull request as ready for review June 24, 2021 20:04
@toolness toolness merged commit 20b91e1 into master Jun 24, 2021
@toolness toolness deleted the contentful-common-strings branch June 24, 2021 20:04
This was referenced Jun 25, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@toolness