Merge pull request #21 from JustFixNYC/pyflakes

Add pyflakes and fix its warnings

aws_schedule_tasks.py

@@ -37,7 +37,6 @@
   AWS_DEFAULT_REGION     The AWS region to use.
 """
 
-import sys
 from typing import List, Dict
 import json
 import boto3
@@ -133,7 +132,7 @@ def create_task(
 
     print(f"Creating rule '{name}' with schedule {schedule_expression}.")
     client = boto3.client('events')
-    response = client.put_rule(
+    client.put_rule(
         Name=name,
         ScheduleExpression=schedule_expression,
         State="ENABLED",

lib/db_perms.py

@@ -1,6 +1,3 @@
-from typing import List
-
-
 def exec_grant_sql(conn, sql: str):
     if not sql:
         return

lib/lastmod.py

@@ -1,4 +1,4 @@
-from typing import Optional, NamedTuple, TypeVar, Type, Dict, List, Mapping
+from typing import Optional, NamedTuple, Dict, List, Mapping
 import requests
 
 from .dbhash import AbstractDbHash

lib/parse_created_tables.py

@@ -3,7 +3,6 @@
 from functools import lru_cache
 import sqlparse
 from sqlparse.sql import Identifier
-from sqlparse import tokens as T
 import nycdb
 
 

load_dataset.py

@@ -1,14 +1,11 @@
 import os
 import sys
-import subprocess
 import contextlib
 import time
 from pathlib import Path
 from typing import NamedTuple, List
 from types import SimpleNamespace
 import urllib.parse
-import psycopg2
-import yaml
 import nycdb.dataset
 from nycdb.dataset import Dataset
 from nycdb.utility import list_wrap
@@ -239,8 +236,6 @@ def main(argv: List[str]=sys.argv):
 
     NYCDB_DATA_DIR.mkdir(parents=True, exist_ok=True)
 
-    tables = get_dataset_tables()
-
     dataset = os.environ.get('DATASET', '')
 
     if len(argv) > 1:

requirements.dev.txt

@@ -6,3 +6,4 @@ boto3
 docopt
 python-dotenv
 requests-mock
+pyflakes==2.1.0

tests/test_load_dataset.py

@@ -1,9 +1,6 @@
-import os
-import time
 import subprocess
 from unittest.mock import patch
 from typing import Dict
-import urllib.parse
 import pytest
 import nycdb.dataset
 

tests/test_pyflakes.py

@@ -0,0 +1,15 @@
+from pathlib import Path
+import subprocess
+import glob
+
+
+ROOT_DIR = Path(__file__).parent.parent.resolve()
+
+
+def test_pyflakes_works():
+    subprocess.check_call([
+        'pyflakes',
+        *glob.glob(str(ROOT_DIR / '*.py')),
+        'lib',
+        'tests'
+    ], cwd=ROOT_DIR)