Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Heroku preboot, speed up production deploys. #1366

Merged
merged 4 commits into from
May 4, 2020

Conversation

toolness
Copy link
Collaborator

@toolness toolness commented May 4, 2020

This adds support for Heroku preboot. If it's enabled, we don't enter maintenance mode at all, resulting in a zero-downtime deploy; otherwise, we behave as normal, entering maintenance mode before doing any migrations.

This basically means that we need to disable preboot if we ever make any migrations that will cause the old version of the code to crash. Once we've successfully done a deploy with Preboot, I'll update our Deployment wiki page with new instructions.

It also prevents tests from being run on the production branch. This is a bit of a bold move but I've provided the rationale in a comment in our circle.yml.

                # This is a bit counter-intuitive, but we've been extremely
                # diligent about only pushing to production once something
                # has been verified to pass CI on master. Because of this,
                # it's wasted effort to run the exact same tests on production
                # when we push to it, particularly since the merge on
                # production is a fast-forward merge and therefore represents
                # the exact same code that's already been tested on master.

Taken together, both changes should make deploys to production much faster without introducing risk.

@toolness toolness changed the title Add support for Heroku preboot. Add support for Heroku preboot and speed up production deploys. May 4, 2020
@toolness toolness changed the title Add support for Heroku preboot and speed up production deploys. Add Heroku preboot support, speed up production deploys. May 4, 2020
@toolness toolness changed the title Add Heroku preboot support, speed up production deploys. Support Heroku preboot, speed up production deploys. May 4, 2020
@toolness toolness merged commit be0ae4d into master May 4, 2020
@toolness toolness deleted the support-heroku-preboot branch May 4, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant