Support Heroku preboot, speed up production deploys. #1366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Heroku preboot. If it's enabled, we don't enter maintenance mode at all, resulting in a zero-downtime deploy; otherwise, we behave as normal, entering maintenance mode before doing any migrations.
This basically means that we need to disable preboot if we ever make any migrations that will cause the old version of the code to crash. Once we've successfully done a deploy with Preboot, I'll update our Deployment wiki page with new instructions.
It also prevents tests from being run on the
production
branch. This is a bit of a bold move but I've provided the rationale in a comment in ourcircle.yml
.Taken together, both changes should make deploys to production much faster without introducing risk.