Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use Python 3.8. #923

Merged
merged 5 commits into from
Nov 8, 2019
Merged

Actually use Python 3.8. #923

merged 5 commits into from
Nov 8, 2019

Conversation

toolness
Copy link
Collaborator

@toolness toolness commented Nov 8, 2019

This fixes #922 and ensures that we always use Python 3.8. It also adds some tests to ensure that we're always using the expected version of Python going forward.

To do

  • Add a dev/prod test that makes sure the Pipfile specifies the right version of Python.
  • Uncomment test case lines commented-out in Put online rental history users on a TextIt follow-up campaign. #921.
  • Consider adding another field to the healthcheck (or extended healthcheck) that includes the current Python version. (I ended up doing this; I had some concerns about security but since everything in this project is open source, it seemed moot since attackers can easily tell what version of Python we're using by looking at our source code.)

@toolness toolness marked this pull request as ready for review November 8, 2019 15:08
@toolness toolness merged commit dc79fe2 into master Nov 8, 2019
@toolness toolness deleted the actually-use-python-3.8 branch November 8, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipfile.lock specifies Python 3.7
1 participant