Move WoW db config out to a YAML file. #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to load/update the WoW database from our containerized DB updater at JustFixNYC/nycdb-k8s-loader#22. One simple way to do this is by putting all our database configuration into a YAML file, similar to what NYCDB is already doing.
This PR moves the names of all the NYCDB dataset dependencies and the SQL filenames into a new
who-owns-what.yml
file. It also makes the following changes:We no longer load the
pluto_17v1
dataset; it seems this was entirely superseded bypluto_18v1
, although I should check with @sraby to make sure this is OK.The
--update
option fordbtool.py builddb
now wipes all nycdb data instead of just a subset of tables. This simplified the structure of the YAML and seems OK since nycdb-k8s-loader will now be responsible for updating WoW in a more rigorous manner. If we really want to add this feature back in, we might want to add a separate flag that allows the user to manually specify which datasets to refresh.It automatically figures out what the tables in a dataset are by consulting the
nycdb
module.