Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify node version 12 or higher in package.json #324

Merged
merged 1 commit into from
Jul 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ With this website, you can find crucial information about who is responsible for

![Imgur](http://i.imgur.com/cYw4gyU.jpg)


**This project is currently in active development!**

## Architecture
Expand All @@ -17,8 +16,8 @@ This site is built on top of the critical work done by [@aepyornis](https://gith

Backend logic and data manipulation is largely handled by making calls to PostgreSQL functions and prebuilding results into tables whenever possible to avoid complex queries made per-request. for the SQL code that provides this functionality, see:

* the [hpd-registration](https://github.com/nycdb/nycdb/tree/master/src/nycdb/sql/hpd_registrations) scripts of `nycdb`, and
* the [sql](./sql) directory of this repository.
- the [hpd-registration](https://github.com/nycdb/nycdb/tree/master/src/nycdb/sql/hpd_registrations) scripts of `nycdb`, and
- the [sql](./sql) directory of this repository.

#### Backend

Expand Down Expand Up @@ -60,7 +59,7 @@ Alternatively, you can load a small test dataset with:
python dbtool.py loadtestdata
```

After that, make sure you have node/npm/[yarn](https://yarnpkg.com/en/) and then run:
After that, make sure you have Node 12 or higher installed as well as [yarn](https://yarnpkg.com/en/), and then run:

```
cd client
Expand Down Expand Up @@ -139,7 +138,7 @@ clicking on the "All Year Management" portfolio on the
home page.

Note: If you would like to connect your Docker instance to an external postgres database, you
can update the `DATABASE_URL` [server-side env variable](https://github.com/JustFixNYC/who-owns-what/blob/master/.env.sample) with your remote db's connection URI.
can update the `DATABASE_URL` [server-side env variable](https://github.com/JustFixNYC/who-owns-what/blob/master/.env.sample) with your remote db's connection URI.

## Tests

Expand Down Expand Up @@ -173,7 +172,7 @@ We use BrowserStack Live to make sure that our sites work across browsers, opera
## Updating data

Updating WoW's data is straighforward for about a year, at which point it eventually needs to look at
different datasets in order to be up-to-date. For example, because it uses the PLUTO dataset, it needs
different datasets in order to be up-to-date. For example, because it uses the PLUTO dataset, it needs
to always look at a reasonably recent version, which can be non-trivial because that dataset's schema
changes from one revision to another.

Expand Down Expand Up @@ -201,7 +200,7 @@ Note also that the
project may be useful for keeping the WoW database up-to-date on a day-to-day
basis.

[NYCDB]: https://github.com/nycdb/nycdb
[nycdb]: https://github.com/nycdb/nycdb
[`requirements-dev.txt`]: requirements-dev.txt
[`who-owns-what.yml`]: who-owns-what.yml
[`tests/generate_factory_from_csv.py`]: tests/generate_factory_from_csv.py
Expand Down
3 changes: 3 additions & 0 deletions client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@
"npm-run-all": "^4.0.2",
"prettier": "2.0.5"
},
"engines": {
"node": ">=12.0.0"
},
"browserslist": [
">0.2%",
"not dead",
Expand Down