Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 10.x Compatibility #50

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l10-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift updated your build matrix for Laravel 10. However, since you are supporting older versions of Laravel, you need to add the following exclusions:

exclude:
  - laravel: 10.*
    php: 8.0

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 10. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/LaravelPostcodes.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "juststeveking/laravel-postcodes": "dev-l10-compatibility",
    }
}

Finally, run: composer update

@GC-Mark
Copy link

GC-Mark commented May 10, 2023

Any chance of getting this merged and released? 🙏

Thanks

@JustSteveKing JustSteveKing merged commit 72d344e into JustSteveKing:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants