Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplitView Pane enhancements. #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chrisleyva
Copy link

  1. The SplitView pane is now closed when selecting the previously selected MenuItem.

  2. The swiping gesture logic has been fixed to improve the experience of using the swipable SplitView.

Review on Reviewable

Previously, the SplitView pane would stay open when the currently
selected MenuItem is selected again. This has been fixed.
A swipe gesture should only ever be interpreted as horizontal or
vertical—not both. Previously, if IsPanSelectorEnabled was true, a
vertical swipe would usually open the SplitView pane. Other visual
improvements were made to enhance the swiping experience.
@chrisleyva
Copy link
Author

I also fixed up the comments in ManipulationCompleted. :-)

I just added punctuation and capitalized the first letter of each. I only modified the comments in that method since it's the only method I modified.

But really nice work on this control. I really like the use of the ListBox, too.

@JustinXinLiu
Copy link
Owner

Thanks! But looks like the changes you made in the ManipulationCompleted breaks the up and down pan gesture. :(

@JustinXinLiu
Copy link
Owner

Also I'd like to keep the code in Shell.xaml.cs and ShellViewModel.cs intact 'cause I actually borrowed them from here.

@chrisleyva
Copy link
Author

Sorry. The up and down pan was working for me :-(
I tested it quite a bit and I feel like it behaved smoothly.

Also, the link you posted is dead.

@JustinXinLiu
Copy link
Owner

Sorry, just updated the link.

Try this:

  1. Open the pane and pan to select the last item;
  2. Open the pane again and try to move up your finger just a little bit.

You will notice that the very top item gets highlighted, which is wrong. The 2nd last item should be highlighted instead.

@chrisleyva
Copy link
Author

I'll give that a shot. But before my changes, I noticed that both the up/down pan and open/close swipe behaved in an unusual way.

I'll take a look a bit later and see if there is a way to redo my fix without modifying Shell/ShellViewModel and without breaking the up/down pan.

@JustinXinLiu
Copy link
Owner

Thanks @chrisleyva ! Appreciate your help on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants