Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta Apple (Mac OS & iOS) Support #229

Merged
merged 20 commits into from
Apr 3, 2023
Merged

Conversation

cedrickcooke
Copy link
Contributor

The basics of rendering and interaction are in (likely with bugs). Each Swift consumer will have to do its own equivalent for ElementView -- I'd like to publish a cocoapod or something, but the limitation of 1 kotlin library per Swift app means that you couldn't use it if you had your own Kotlin library to consume, which would lose the major advantage of using Krayon.

In the future I'll publish a copy-pasteable snippet, but for now I'm happy with how this is as a beta.

@cedrickcooke cedrickcooke added minor Changes that should bump the MINOR version number apple labels Mar 30, 2023
@github-actions
Copy link

github-actions bot commented Mar 30, 2023

Test Results

14 files  14 suites   22s ⏱️
45 tests 45 ✔️ 0 💤 0
90 runs  90 ✔️ 0 💤 0

Results for commit a82f564.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #229 (a82f564) into main (8c86321) will increase coverage by 8.62%.
The diff coverage is 70.88%.

@@             Coverage Diff              @@
##               main     #229      +/-   ##
============================================
+ Coverage     70.47%   79.10%   +8.62%     
- Complexity       67       90      +23     
============================================
  Files            31       25       -6     
  Lines           918     1254     +336     
  Branches         83      124      +41     
============================================
+ Hits            647      992     +345     
+ Misses          236      203      -33     
- Partials         35       59      +24     
Impacted Files Coverage Δ
color/src/commonMain/kotlin/NextColor.kt 75.00% <ø> (ø)
kanvas/src/commonMain/kotlin/svg/PathString.kt 0.00% <0.00%> (-43.59%) ⬇️
shape/src/commonMain/kotlin/curve/Linear.kt 0.00% <0.00%> (ø)
kanvas/src/commonMain/kotlin/Clip.kt 41.17% <23.07%> (-18.83%) ⬇️
kanvas/src/commonMain/kotlin/Ellipse.kt 81.25% <25.00%> (-4.47%) ⬇️
kanvas/src/commonMain/kotlin/Transform.kt 72.97% <42.85%> (-11.41%) ⬇️
...vas/src/commonMain/kotlin/svg/PathStringBuilder.kt 56.00% <56.00%> (ø)
kanvas/src/commonMain/kotlin/SegmentedPath.kt 58.76% <58.76%> (ø)
color/src/commonMain/kotlin/Color.kt 89.47% <83.33%> (+1.23%) ⬆️
kanvas/src/commonMain/kotlin/Path.kt 83.33% <83.33%> (ø)
... and 10 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cedrickcooke cedrickcooke marked this pull request as ready for review March 31, 2023 00:42
@cedrickcooke cedrickcooke requested a review from a team as a code owner March 31, 2023 00:42
Copy link
Member

@twyatt twyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass 1/x

kanvas/README.md Outdated Show resolved Hide resolved
kanvas/README.md Outdated Show resolved Hide resolved
kanvas/README.md Outdated Show resolved Hide resolved
kanvas/README.md Show resolved Hide resolved
kanvas/src/nativeDarwinMain/kotlin/CGContextKanvas.kt Outdated Show resolved Hide resolved
@twyatt twyatt self-requested a review March 31, 2023 06:48
Copy link
Member

@twyatt twyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this-so

gradle/libs.versions.toml Outdated Show resolved Hide resolved
kanvas/src/nativeDarwinMain/kotlin/IsPointInCGPath.kt Outdated Show resolved Hide resolved
@cedrickcooke
Copy link
Contributor Author

@davidtaylor-juul did you want to take a look at this before it gets merged?

Copy link
Contributor

@davidtaylor-juul davidtaylor-juul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cedrickcooke cedrickcooke merged commit 62fdf4f into main Apr 3, 2023
@cedrickcooke cedrickcooke mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple minor Changes that should bump the MINOR version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants