-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta Apple (Mac OS & iOS) Support #229
Conversation
Codecov Report
@@ Coverage Diff @@
## main #229 +/- ##
============================================
+ Coverage 70.47% 79.10% +8.62%
- Complexity 67 90 +23
============================================
Files 31 25 -6
Lines 918 1254 +336
Branches 83 124 +41
============================================
+ Hits 647 992 +345
+ Misses 236 203 -33
- Partials 35 59 +24
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass 1/x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidtaylor-juul did you want to take a look at this before it gets merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The basics of rendering and interaction are in (likely with bugs). Each Swift consumer will have to do its own equivalent for ElementView -- I'd like to publish a cocoapod or something, but the limitation of 1 kotlin library per Swift app means that you couldn't use it if you had your own Kotlin library to consume, which would lose the major advantage of using Krayon.
In the future I'll publish a copy-pasteable snippet, but for now I'm happy with how this is as a beta.