Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agp to v8 (major) #243

Merged
merged 3 commits into from
May 16, 2023
Merged

Update agp to v8 (major) #243

merged 3 commits into from
May 16, 2023

Conversation

juul-mobile-bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
com.android.library (source) plugin major 7.4.1 -> 8.0.1
com.android.application (source) plugin major 7.4.1 -> 8.0.1

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the logs for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@twyatt
Copy link
Member

twyatt commented May 15, 2023

Blocked by #244.

Copy link
Contributor

@davidtaylor-juul davidtaylor-juul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approved pending dependent PR

@@ -1,5 +1,5 @@
[versions]
agp = "7.4.1" # 7.4.1 is the maximum version supported by IDEA 2023.1
agp = "8.0.1" # 7.4.1 is the maximum version supported by IDEA 2023.1
Copy link
Member

@twyatt twyatt May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cedrickcooke where did you find the AGP / IDEA version compatibility?
I see that IDEA 2023.1.1 is out, but I'm having trouble figuring out if it supports this bump (AGP 8.0.1).
Did you just spin up the IDE to try it?

@twyatt twyatt self-requested a review May 15, 2023 18:42
@github-actions
Copy link

Test Results

  50 files    50 suites   23s ⏱️
252 tests 252 ✔️ 0 💤 0
297 runs  297 ✔️ 0 💤 0

Results for commit 6d8f7c1.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #243 (6d8f7c1) into main (8c86321) will increase coverage by 8.62%.
The diff coverage is 70.88%.

@@             Coverage Diff              @@
##               main     #243      +/-   ##
============================================
+ Coverage     70.47%   79.10%   +8.62%     
- Complexity       67       90      +23     
============================================
  Files            31       25       -6     
  Lines           918     1254     +336     
  Branches         83      124      +41     
============================================
+ Hits            647      992     +345     
+ Misses          236      203      -33     
- Partials         35       59      +24     
Impacted Files Coverage Δ
color/src/commonMain/kotlin/NextColor.kt 75.00% <ø> (ø)
kanvas/src/commonMain/kotlin/svg/PathString.kt 0.00% <0.00%> (-43.59%) ⬇️
shape/src/commonMain/kotlin/curve/Linear.kt 0.00% <0.00%> (ø)
kanvas/src/commonMain/kotlin/Clip.kt 41.17% <23.07%> (-18.83%) ⬇️
kanvas/src/commonMain/kotlin/Ellipse.kt 81.25% <25.00%> (-4.47%) ⬇️
kanvas/src/commonMain/kotlin/Transform.kt 72.97% <42.85%> (-11.41%) ⬇️
...vas/src/commonMain/kotlin/svg/PathStringBuilder.kt 56.00% <56.00%> (ø)
kanvas/src/commonMain/kotlin/SegmentedPath.kt 58.76% <58.76%> (ø)
color/src/commonMain/kotlin/Color.kt 89.47% <83.33%> (+1.23%) ⬆️
kanvas/src/commonMain/kotlin/Path.kt 83.33% <83.33%> (ø)
... and 10 more

... and 4 files with indirect coverage changes

@twyatt
Copy link
Member

twyatt commented May 15, 2023

Waiting on confirmation that this works w/ current IDEA versions (i.e. awaiting approval from @cedrickcooke).

@cedrickcooke
Copy link
Contributor

It's not usually trivial to find. Normally I just launch IDEA and then get grumpy because the AGP version moved too fast. 😆

2023.1.1 bundles the Android plugin at version 2022.1.1.231.8770.65, with no option to update it. You can check the equivalent Android Studio version here. Looks like we're basically trailing a year behind if we want to support IDEA

@twyatt
Copy link
Member

twyatt commented May 16, 2023

Is there a reason you need to use IDEA, or would Android Studio work?

@cedrickcooke
Copy link
Contributor

Android Studio works -- if I need to revert it locally in the future I can.

@cedrickcooke cedrickcooke merged commit 96bd947 into main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants