-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update agp to v8 (major) #243
Conversation
Blocked by #244. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approved pending dependent PR
@@ -1,5 +1,5 @@ | |||
[versions] | |||
agp = "7.4.1" # 7.4.1 is the maximum version supported by IDEA 2023.1 | |||
agp = "8.0.1" # 7.4.1 is the maximum version supported by IDEA 2023.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cedrickcooke where did you find the AGP / IDEA version compatibility?
I see that IDEA 2023.1.1 is out, but I'm having trouble figuring out if it supports this bump (AGP 8.0.1).
Did you just spin up the IDE to try it?
Codecov Report
@@ Coverage Diff @@
## main #243 +/- ##
============================================
+ Coverage 70.47% 79.10% +8.62%
- Complexity 67 90 +23
============================================
Files 31 25 -6
Lines 918 1254 +336
Branches 83 124 +41
============================================
+ Hits 647 992 +345
+ Misses 236 203 -33
- Partials 35 59 +24
|
Waiting on confirmation that this works w/ current IDEA versions (i.e. awaiting approval from @cedrickcooke). |
It's not usually trivial to find. Normally I just launch IDEA and then get grumpy because the AGP version moved too fast. 😆 2023.1.1 bundles the Android plugin at version |
Is there a reason you need to use IDEA, or would Android Studio work? |
Android Studio works -- if I need to revert it locally in the future I can. |
This PR contains the following updates:
7.4.1
->8.0.1
7.4.1
->8.0.1
⚠ Dependency Lookup Warnings ⚠
Warnings were logged while processing this repo. Please check the logs for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.