Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing different HOST headers to be used in ng serve #209

Merged
merged 1 commit into from
May 11, 2018
Merged

Allowing different HOST headers to be used in ng serve #209

merged 1 commit into from
May 11, 2018

Conversation

corentingiraud
Copy link
Member

@corentingiraud corentingiraud commented May 10, 2018 •
edited
Loading

Description of your PR

angular/angular-cli#6349.
What do you think ?

Pre-review TODO

  • PR is rebased on top of origin/master
  • PR provide new tests for new behaviors
  • PR doesn't introduce commented out code
  • PR has been tested locally on the main use cases
  • Documentation have been updated if necessary

@corentingiraud corentingiraud added this to the Sprint 7 milestone May 10, 2018
@corentingiraud corentingiraud force-pushed the dev-allow-different-host branch from 4c87884 to 1b43fcf Compare May 10, 2018 13:56
@corentingiraud corentingiraud requested a review from Embraser01 May 10, 2018 14:35
@Embraser01
Copy link
Member

I don't really understand why we need this? Only if we work remotely in dev (in production we don't use this)

@corentingiraud
Copy link
Member Author

Because I test layout on a MAC in the same network or with my android phone :)

@Embraser01
Copy link
Member

Ok

@Embraser01 Embraser01 merged commit 0dfbc37 into master May 11, 2018
@Embraser01 Embraser01 deleted the dev-allow-different-host branch May 11, 2018 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Embraser01 Embraser01 Embraser01 approved these changes

Assignees

@Embraser01 Embraser01

Labels
discussion front
Projects
None yet
Milestone
Sprint 7
Development

Successfully merging this pull request may close these issues.
2 participants
@corentingiraud @Embraser01