Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mapping APIKey manifests into secrets #110

Merged
merged 2 commits into from
Jan 17, 2022

Conversation

K-Phoen
Copy link
Owner

@K-Phoen K-Phoen commented Jan 17, 2022

Needs K-Phoen/grabana#161 + some tests

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2022

Codecov Report

Merging #110 (0554cf8) into master (642d965) will decrease coverage by 5.53%.
The diff coverage is 0.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   47.46%   41.93%   -5.54%     
==========================================
  Files          27       31       +4     
  Lines        1616     1834     +218     
==========================================
+ Hits          767      769       +2     
- Misses        824     1040     +216     
  Partials       25       25              
Impacted Files Coverage Δ
internal/pkg/controllers/apikey_controller.go 0.00% <0.00%> (ø)
internal/pkg/controllers/datasource_controller.go 0.00% <0.00%> (ø)
internal/pkg/grafana/apikeys.go 0.00% <0.00%> (ø)
internal/pkg/kubernetes/secrets.go 0.00% <0.00%> (ø)
internal/pkg/kubernetes/valueref.go 0.00% <0.00%> (ø)
api/v1alpha1/apikey_types.go 100.00% <100.00%> (ø)

@K-Phoen K-Phoen marked this pull request as ready for review January 17, 2022 22:57
@K-Phoen K-Phoen merged commit acdf4bc into master Jan 17, 2022
@K-Phoen K-Phoen deleted the api-key-manifest branch January 17, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants