Fix a few linting errors

K-Phoen · Dec 22, 2023 · a604815 · a604815
1 parent 5d05957
commit a604815
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 13 deletions.
diff --git a/encoder/golang/encoder.go b/encoder/golang/encoder.go
@@ -40,7 +40,7 @@ func (encoder *Encoder) EncodeDashboard(dashboard sdk.Board) (string, error) {
 
 	buffer := &bytes.Buffer{}
 	if err := file.Render(buffer); err != nil {
-		return "", nil
+		return "", err
 	}
 
 	return buffer.String(), nil

diff --git a/encoder/golang/gauge.go b/encoder/golang/gauge.go
@@ -50,7 +50,7 @@ func (encoder *Encoder) encodeGaugeSettings(panel sdk.Panel) []jen.Code {
 }
 
 func (encoder *Encoder) encodeGaugeOrientation(panel sdk.Panel) jen.Code {
-	orientationConst := "OrientationAuto"
+	var orientationConst string
 	switch panel.GaugePanel.Options.Orientation {
 	case "":
 		orientationConst = "OrientationAuto"

diff --git a/encoder/golang/paneltargets.go b/encoder/golang/paneltargets.go
@@ -96,7 +96,6 @@ func (encoder *Encoder) encodePrometheusTarget(target sdk.Target, grabanaPackage
 		formatConstName = "FormatTimeSeries"
 	default:
 		encoder.logger.Warn("unhandled prometheus target format: using 'time_series' instead", zap.String("format", target.Format))
-
 	}
 
 	// only emit code if the default isn't used

diff --git a/encoder/golang/row.go b/encoder/golang/row.go
@@ -24,9 +24,7 @@ func (encoder *Encoder) encodeRow(row RowIR) *jen.Statement {
 		rowSettings = append(rowSettings, rowQual("Collapse").Call())
 	}
 
-	for _, panel := range row.Panels {
-		rowSettings = append(rowSettings, panel)
-	}
+	rowSettings = append(rowSettings, row.Panels...)
 
 	return dashboardQual("Row").MultiLineCall(rowSettings...)
 }

diff --git a/encoder/golang/stat.go b/encoder/golang/stat.go
@@ -150,10 +150,12 @@ func (encoder *Encoder) encodeStatFieldConfigDefaults(defaults sdk.FieldConfigDe
 		settings = append(settings, statQual("NoValue").Call(lit(defaults.NoValue)))
 	}
 
+	// TODO: thresholds
 	// RelativeThresholds/AbsoluteThresholds
-	if defaults.Thresholds.Mode != "" && len(defaults.Thresholds.Steps) != 0 {
-		// TODO: thresholds
-	}
+	/*
+		if defaults.Thresholds.Mode != "" && len(defaults.Thresholds.Steps) != 0 {
+		}
+	*/
 
 	return settings
 }

diff --git a/encoder/golang/timeseries.go b/encoder/golang/timeseries.go
@@ -167,7 +167,7 @@ func (encoder *Encoder) encodeTimeseriesVizualization(panel sdk.Panel) []jen.Cod
 
 	// Line interpolation mode
 	if fieldConfig.Defaults.Custom.DrawStyle == "line" {
-		lineInterpolationConst := "Linear"
+		var lineInterpolationConst string
 
 		switch fieldConfig.Defaults.Custom.LineInterpolation {
 		case "smooth":
@@ -193,7 +193,7 @@ func (encoder *Encoder) encodeTimeseriesVizualization(panel sdk.Panel) []jen.Cod
 	}
 
 	// Tooltip mode
-	toolTipModeConst := "SingleSeries"
+	var toolTipModeConst string
 	switch panel.TimeseriesPanel.Options.Tooltip.Mode {
 	case "none":
 		toolTipModeConst = "NoSeries"
@@ -211,7 +211,7 @@ func (encoder *Encoder) encodeTimeseriesVizualization(panel sdk.Panel) []jen.Cod
 	}
 
 	// Gradient mode
-	gradientModeConst := "Opacity"
+	var gradientModeConst string
 	switch fieldConfig.Defaults.Custom.GradientMode {
 	case "none":
 		gradientModeConst = "NoGradient"
@@ -231,7 +231,7 @@ func (encoder *Encoder) encodeTimeseriesVizualization(panel sdk.Panel) []jen.Cod
 	}
 
 	// Stacking mode
-	stackingModeConst := "Unstacked"
+	var stackingModeConst string
 	switch fieldConfig.Defaults.Custom.Stacking.Mode {
 	case "none":
 		stackingModeConst = "Unstacked"