Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid numeric domains are considered invalid in strict mode #72

Closed
delphaber opened this issue Apr 1, 2021 · 2 comments
Closed

Valid numeric domains are considered invalid in strict mode #72

delphaber opened this issue Apr 1, 2021 · 2 comments

Comments

@delphaber
Copy link
Contributor

Emails from domains like 163.com, 139.com are marked as invalid. But they are valid: those are common emails in China :)

I've created a failing PR for this
@delphaber
Copy link
Contributor Author

Linked to: #68 and #70

@delphaber delphaber changed the title Valid numeric domains are considered invalid strict mode Valid numeric domains are considered invalid in strict mode Apr 1, 2021
karlwilbur added a commit that referenced this issue Apr 5, 2021
@karlwilbur
Merge branch 'bugfix-72-fix-regexp-for-numeric-domains' into develop
4703302 
* bugfix-72-fix-regexp-for-numeric-domains:
  Fix regexp for numeric domains (fixes #72)
  Add `EmailValidator::Error` class, raise `EmailValidator::Error` when invalid `mode`
  Add checks for double dash in domain
  Fix specs for numeric-only domains labels
  Add checks for numeric-only TLDs in tests
  Add tests to ensure that `regexp` returns expected value
  Add failing test: strict mode should accept numbers only domains
karlwilbur added a commit that referenced this issue Apr 5, 2021
@karlwilbur
Merge branch 'develop'
4b24282 
* develop:
  Bump version to `2.2.3`
  Fix regexp for numeric domains (fixes #72)
  Add `EmailValidator::Error` class, raise `EmailValidator::Error` when invalid `mode`
  Add checks for double dash in domain
  Fix specs for numeric-only domains labels
  Add checks for numeric-only TLDs in tests
  Add tests to ensure that `regexp` returns expected value
  Bump y18n from 3.2.1 to 3.2.2
  Add failing test: strict mode should accept numbers only domains
  Update .travis.yml
@delphaber
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@delphaber