Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc - Fix excessive FAK items are dropped on floor as single items #456

Conversation

Tapawingo
Copy link
Contributor

When merged this pull request will:

  • Fix excessive FAK items being dropped as single items
  • Resolve issue reported on discord

IMPORTANT

  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@Tapawingo Tapawingo marked this pull request as ready for review December 21, 2023 22:20
@BlueTheKing BlueTheKing changed the title Fix - Excessive FAK items are dropped on floor as single items Misc - Fix excessive FAK items are dropped on floor as single items Dec 21, 2023
@BlueTheKing BlueTheKing added the kind/bug fix Release Notes: **FIXED:** label Dec 21, 2023
@BlueTheKing BlueTheKing added this to the 2.14.0 milestone Dec 21, 2023
@Tapawingo
Copy link
Contributor Author

Alternatively we can pass the created groundContainer as unit in the next loop iteration skipping the need for the extra forEach (would be slightly more performant). However, this would introduce possible unwanted behavior like items that can actually fit in the unit's inventory being dropped.

@MiszczuZPolski MiszczuZPolski modified the milestones: 2.14.0, 2.13.4 Dec 28, 2023
@MiszczuZPolski MiszczuZPolski modified the milestones: 2.13.4, 2.14.0 Jan 11, 2024
@MiszczuZPolski MiszczuZPolski merged commit bad40dc into KAT-Advanced-Medical:dev-Tomcat Mar 1, 2024
3 checks passed
@Tapawingo Tapawingo deleted the fixDroppedAsSingleItems branch March 1, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug fix Release Notes: **FIXED:** status/tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants