Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re: Hide the drop indicators #334 #337

Closed
pklaffert opened this issue Jan 19, 2023 · 3 comments
Closed

Re: Hide the drop indicators #334 #337

pklaffert opened this issue Jan 19, 2023 · 3 comments
Assignees
@iamsergio

Comments

@pklaffert
Copy link

Hi sergio,

the provided way to set a DropIndicatorAllowedFunc is not completely satisfying because it is only evaluated at the start of the dragging operation.
We need a way to show / hide the drop indicators also during the dragging similar to the way Visual Studio works

docking-inidcator

Best regards,
Philipp
@iamsergio iamsergio self-assigned this Jan 24, 2023
@iamsergio
Copy link
Contributor

ok will have a look.
when do you need it done ?

@iamsergio iamsergio mentioned this issue Jan 24, 2023
Closed
@pklaffert
Copy link
Author

Hi,

it is not, too urgent but it would be nice to have by mid / end of February.

iamsergio added a commit that referenced this issue Feb 7, 2023
@iamsergio
Fix setDropIndicatorsInhibited(false) not showing drop indicators
57aded2 
It required the user to move the mouse, which was OK but we can do
better.

Now, KDDW will automaticallt re-show the drop indicators if we're in
the middle of a drag operation.

Required for issue #334 and issue #337
iamsergio added a commit that referenced this issue Feb 7, 2023
@iamsergio
examples: Show how to hide dock indicators when ctrl is pressed
af455bb 
Fixes issue #334 and issue #337.
Won't add this directly into the library, as each project
has different requirements regarding this.

It's easy to do in application code though.
@iamsergio
Copy link
Contributor

This is done, you'll need to pull the latest 1.7 which has a bug fix in the library.
It also has an example of how to use the KDDW API to achieve this, see commit af455bb

The requirement itself is not generic enough to make it to the library, but can easily be done on the app side, as shown in the example.

@tlaemmlein tlaemmlein mentioned this issue Feb 28, 2023
Closed
iamsergio added a commit that referenced this issue Mar 8, 2023
@iamsergio
Fix setDropIndicatorsInhibited(false) not showing drop indicators
17d166b 
It required the user to move the mouse, which was OK but we can do
better.

Now, KDDW will automaticallt re-show the drop indicators if we're in
the middle of a drag operation.

Required for issue #334 and issue #337

(cherry-picked from commit 57aded2)
iamsergio added a commit that referenced this issue Mar 8, 2023
@iamsergio
examples: Show how to hide dock indicators when ctrl is pressed
b0836ea 
Fixes issue #334 and issue #337.
Won't add this directly into the library, as each project
has different requirements regarding this.

It's easy to do in application code though.

(cherry picked from commit af455bb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamsergio iamsergio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iamsergio @pklaffert