Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error concerning KDBindings #557

Closed
arietto opened this issue Dec 20, 2024 · 3 comments
Closed

Build error concerning KDBindings #557

arietto opened this issue Dec 20, 2024 · 3 comments
Assignees

Comments

@arietto
Copy link

arietto commented Dec 20, 2024

Hello! I am trying to build C++ app, which links to KDDockWidgets (v2.2.0) under Windows and Qt 5.15.2.
The library has been successfully built. But the consumer cannot be built due to missing KDBindings.lib.
How should I tweak KDDockWidgets build options in order to build KDBindings.lib?
Should I download external KDBindings repository?

@iamsergio
Copy link
Contributor

Hi, I can't reproduce the problem. Would you be able to attach a minimal main.cpp + CMakeLists.txt that shows it, then I'd be able to fix it

Are you installing KDDockWidgets (make install or equivalent), or using KDDW as a submodule ?

@iamsergio iamsergio self-assigned this Dec 20, 2024
@arietto
Copy link
Author

arietto commented Dec 23, 2024

test_dock_widgets.zip
I've installed static version of KDDockWidgets via nmake (Visual Studio 2022 command prompt).
I've got the following fragment in KDDockWidgetsTargets.cmake:
set_target_properties(KDAB::kddockwidgets PROPERTIES INTERFACE_COMPILE_DEFINITIONS "KDDOCKWIDGETS_STATICLIB;KDDW_FRONTEND_QTWIDGETS;KDDW_FRONTEND_QT" INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include/" INTERFACE_LINK_LIBRARIES "Qt5::Widgets;\$<LINK_ONLY:Qt5::WidgetsPrivate>;\$<LINK_ONLY:KDBindings>; \$<LINK_ONLY:Qt5::GuiPrivate>;\$<LINK_ONLY:dwmapi>")
I mean LINK_ONLY:KDBindings entry.
I've set the following build options:

CMAKE_DEBUG_POSTFIX="d"
KDDockWidgets_EXAMPLES="0"
KDDockWidgets_STATIC="1"
KDDockWidgets_DOCS="0"
KDDockWidgets_QT6="0"
KDDockWidgets_FRONTENDS="qtwidgets"

iamsergio added a commit that referenced this issue Dec 23, 2024
iamsergio added a commit that referenced this issue Dec 23, 2024
iamsergio added a commit that referenced this issue Dec 24, 2024
iamsergio added a commit that referenced this issue Dec 24, 2024
@iamsergio
Copy link
Contributor

try latest main branch, should be fixed

iamsergio added a commit that referenced this issue Dec 24, 2024
fixes issue #557

(cherry picked from commit a1e2279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants