-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Warning typesystem_kddockwidgets.xml #552
Conversation
Small fix, remove duplicate enum, add rejection value
for more information, see https://pre-commit.ci
forgot a dup
add explicit import to reduce warnings
for more information, see https://pre-commit.ci
@@ -33,3 +33,6 @@ | |||
#include <kddockwidgets/qtwidgets/views/MainWindow.h> | |||
#include <kddockwidgets/qtwidgets/views/DockWidget.h> | |||
#include <kddockwidgets/qtcommon/View.h> | |||
#for cbor warnings and enum differ in qualifiers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't valid C++
@@ -54,35 +51,44 @@ | |||
<value-type name="InitialOption"> | |||
<include file-name="kddockwidgets/KDDockWidgets.h" location="global"/> | |||
</value-type> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated white space change
I've removed the duplications in #559 Can't merge this one since it doesn't build thanks for the patch! |
Sorry wasn't here last week to fix. I feel soo stupid for "#" comment. will make better pr next time and took more time to review. Thanks for reviewing it and use it :) |
Small fix, remove duplicate enum, add rejection value
Small contribution, not yet used to PR. Hope it can help
Buid with 6.8.1